Commit 401d1c4f5d2 ("common: Drop asm/global_data.h from common header") broke CONFIG_CMD_SQUASHFS=y

[Tom Rini]

On Fri, Feb 26, 2021 at 01:34:29PM +0100, Pali Rohár wrote:

> Hello!
> 
> Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop
> asm/global_data.h from common header") broke compilation of
> squashfs filesystem when CONFIG_CMD_SQUASHFS=y is enabled.
> 
> Here is console output:
> 
> fs/squashfs/sqfs_inode.c: In function ‘sqfs_find_inode’:
> fs/squashfs/sqfs_inode.c:121:18: warning: implicit declaration of function ‘le32_to_cpu’ [-Wimplicit-function-declaration]
>   for (k = 0; k < le32_to_cpu(inode_count); k++) {
>                   ^~~~~~~~~~~
>   LD      u-boot
> aarch64-linux-gnu-ld.bfd: fs/built-in.o: in function `sqfs_find_inode':
> /u-boot/fs/squashfs/sqfs_inode.c:126: undefined reference to `le32_to_cpu'
> aarch64-linux-gnu-ld.bfd: /u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu'
> Segmentation fault
> make: *** [Makefile:1765: u-boot] Error 139
> make: *** Deleting file 'u-boot'
> 
> When compiling U-Boot prior that commit, there is no error.
> 
> Simon and Tom: you have signed problematic mentioned commit. Could you
> please look at it?

Yes, that file probably needs <compiler.h>, please check.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210226/1a1cfbbe/attachment.sig>