[PATCH] serial: ns16550: Correct the base address type

Simon Glass sjg at chromium.org
Fri Feb 26 15:05:47 CET 2021


Hi Bin,

On Fri, 26 Feb 2021 at 02:32, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Sun, Feb 7, 2021 at 8:16 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > On Wed, 3 Feb 2021 at 06:22, Bin Meng <bmeng.cn at gmail.com> wrote:
> > >
> > > Currently ns16550_serial_assign_base() treats the argument 'base'
> > > with type `ulong`. This is incorrect because the base address was
> > > obtained from device tree with type `fdt_addr_t` that can represent
> > > a physical address larger than 32-bit in a 32-bit system.
> > >
> > > Fixes: 9e6ce62190b7 ("serial: ns16550: Fix ordering of getting base address")
> > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > > ---
> > >
> > >  drivers/serial/ns16550.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > Applied to u-boot-dm, thanks!
>
> It looks like this is still not in u-boot/master yet?

Yes we hit a snag as Tom wants the  of-platdata stuff in -next
instead. I'll make a note to mess around with dm/master a bit and send
a pull request with just a few fixes, including this one.

Regards,
Simon


More information about the U-Boot mailing list