[PATCH 2/4] pinephone_defconfig: reduce boot delay

Andre Przywara andre.przywara at arm.com
Sun Feb 28 16:22:19 CET 2021


On Thu, 25 Feb 2021 21:58:38 +0100
Maxime Ripard <maxime at cerno.tech> wrote:

Hi,

> On Thu, Feb 25, 2021 at 05:02:40PM +0000, André Przywara wrote:
> > On 20/02/2021 12:14, Nicolas Boulenguez wrote:  
> > > From: Arnaud Ferraris <arnaud.ferraris at collabora.com>
> > > 
> > > On a cellular phone, the vast majority of users can be expected to
> > > have no serial console connected and prefer a short boot.  
> > 
> > It's a bit tricky to break in with a delay of 0, but indeed most users
> > won't care, so looks fine to me.
> > 
> > But it's missing a Signed-off-by: line.  
> 
> I'm not sure we should start accepting custom boards changes like it's
> done here, this will only lead to inconsistencies between boards in the
> long run.

I am a bit undecided, I see merits in both arguments.
 
> And a defconfig is really easy to change anyway, even when it's
> integrated in build systems

Nicolas, could you live with:

$ sed -i s/^CONFIG_BOOTDELAY=2/CONFIG_BOOTDELAY=0/ .config

in your build system? Or is the U-Boot build generic?

Cheers,
Andre


More information about the U-Boot mailing list