[PATCH 2/3 v3] efi_loader: Force a sinlge FMP instance per hardware store

Ilias Apalodimas ilias.apalodimas at linaro.org
Fri Jul 2 09:32:42 CEST 2021


> > +	bool "FMP driver for FIT images"
[...]
> > +	depends on FIT
> > +	depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT
> 
> Should here be:
> 
> 	depends on SANDBOX || (!SANDBOX && !EFI_CAPSULE_FIRMWARE_RAW)
> 
Well on of them is enough and makes them mutually exclusive. If you choose 
EFI_CAPSULE_FIRMWARE_RAW in this specific case the FIT variant will dissapear. 

I dont mind adding it for completeness, up to you

Cheers
/Ilias

> Best regards
> 
> Heinrich
> 
> > +	select UPDATE_FIT
> > +	select DFU
> > +	select EFI_CAPSULE_FIRMWARE
> > +	help
> > +	  Select this option if you want to enable firmware management protocol
> > +	  driver for FIT image
> > +
> > +config EFI_CAPSULE_FIRMWARE_RAW
> > +	bool "FMP driver for raw images"
> > +	depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT
> > +	depends on SANDBOX || (!SANDBOX && !EFI_CAPSULE_FIRMWARE_FIT)
> > +	select DFU_WRITE_ALT
> > +	select DFU
> > +	select EFI_CAPSULE_FIRMWARE
> > +	help
> > +	  Select this option if you want to enable firmware management protocol
> > +	  driver for raw image
> > +
> >   config EFI_CAPSULE_AUTHENTICATE
> >   	bool "Update Capsule authentication"
> >   	depends on EFI_CAPSULE_FIRMWARE
> > @@ -181,29 +203,6 @@ config EFI_CAPSULE_AUTHENTICATE
> >   	  Select this option if you want to enable capsule
> >   	  authentication
> > 
> > -config EFI_CAPSULE_FIRMWARE_FIT
> > -	bool "FMP driver for FIT image"
> > -	depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT
> > -	depends on FIT
> > -	select UPDATE_FIT
> > -	select DFU
> > -	select EFI_CAPSULE_FIRMWARE
> > -	default n
> > -	help
> > -	  Select this option if you want to enable firmware management protocol
> > -	  driver for FIT image
> > -
> > -config EFI_CAPSULE_FIRMWARE_RAW
> > -	bool "FMP driver for raw image"
> > -	depends on EFI_CAPSULE_FIRMWARE_MANAGEMENT
> > -	select DFU
> > -	select DFU_WRITE_ALT
> > -	select EFI_CAPSULE_FIRMWARE
> > -	default n
> > -	help
> > -	  Select this option if you want to enable firmware management protocol
> > -	  driver for raw image
> > -
> >   config EFI_DEVICE_PATH_TO_TEXT
> >   	bool "Device path to text protocol"
> >   	default y
> > 
> 


More information about the U-Boot mailing list