[PATCH v2 1/2] usb: ehci-mx6: move mode set/detect to probe

Tim Harvey tharvey at gateworks.com
Fri Jul 2 21:43:17 CEST 2021


On Fri, Jul 2, 2021 at 12:17 PM Marek Vasut <marex at denx.de> wrote:
>
> On 7/2/21 2:15 AM, Tim Harvey wrote:
> > There is no need to set and/or detect mode in of_to_plat
>
> Are you absolutely sure of that ?
>
> It used to be necessary to know the core mode early to determine which
> driver (the gadget or host) to probe, that's why this code was in
> of_to_plat.
>

Marek,

I can't find a reason for the core mode to be known early and have
tested it both with host and gadget mode on IMX6 and IMX8MM. Fabio has
tested this change also (from another thread) with SPL SDP on IMX8MM
(granted the SPL is not using DM_USB for that).

It appears I accidentally forgot to cc the uboot list so I'll need to
resend this at any rate.

Best regards,

Tim


More information about the U-Boot mailing list