[PATCH 5/6] patman: Use bytearray instead of string
Simon Glass
sjg at chromium.org
Tue Jul 6 18:36:40 CEST 2021
If the process outputs a lot of data on stdout this can be quite slow,
since the bytestring is regenerated each time. Use a bytearray instead.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
tools/patman/cros_subprocess.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/patman/cros_subprocess.py b/tools/patman/cros_subprocess.py
index efd0a5aaf72..fdd51386856 100644
--- a/tools/patman/cros_subprocess.py
+++ b/tools/patman/cros_subprocess.py
@@ -169,11 +169,11 @@ class Popen(subprocess.Popen):
self.stdin.close()
if self.stdout:
read_set.append(self.stdout)
- stdout = b''
+ stdout = bytearray()
if self.stderr and self.stderr != self.stdout:
read_set.append(self.stderr)
- stderr = b''
- combined = b''
+ stderr = bytearray()
+ combined = bytearray()
input_offset = 0
while read_set or write_set:
--
2.32.0.93.g670b81a890-goog
More information about the U-Boot
mailing list