[PATCH v3 8/8] test: add first autoboot unit tests

[Simon Glass]

Hi Steffen,

On Wed, 7 Jul 2021 at 04:39, Steffen Jaeckel
<jaeckel-floss at eyet-services.de> wrote:
>
> Hi Simon,
>
> thanks again for the review!
>
> On 6/26/21 8:32 PM, Simon Glass wrote:
> > On Mon, 21 Jun 2021 at 14:25, Steffen Jaeckel
> > <jaeckel-floss at eyet-services.de> wrote:
> >>
> >> This adds tests for the crypt-based and plain SHA256-based password hashing
> >> algorithms in the autoboot flow.
> >>
> >> Signed-off-by: Steffen Jaeckel <jaeckel-floss at eyet-services.de>
> >> ---
> >>
> >> (no changes since v1)
> >>
> >>  common/Kconfig.boot         |  2 +-
> >>  common/console.c            |  5 +++
> >>  configs/sandbox_defconfig   | 11 +++++
> >>  include/console.h           | 17 +++++++
> >>  include/test/common.h       | 15 +++++++
> >>  include/test/suites.h       |  1 +
> >>  test/Makefile               |  1 +
> >>  test/cmd_ut.c               |  1 +
> >>  test/common/Makefile        |  3 ++
> >>  test/common/cmd_ut_common.c | 22 +++++++++
> >>  test/common/test_autoboot.c | 90 +++++++++++++++++++++++++++++++++++++
> >>  11 files changed, 167 insertions(+), 1 deletion(-)
> >>  create mode 100644 include/test/common.h
> >>  create mode 100644 test/common/Makefile
> >>  create mode 100644 test/common/cmd_ut_common.c
> >>  create mode 100644 test/common/test_autoboot.c
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > but please make sure patman does not give you checkpatch warnings. I
> > see one, I think.
>
> I see two potential candidates
>
> > test/common/test_autoboot.c:27: warning: braces {} are not necessary for single statement blocks
> > test/common/test_autoboot.c:62: warning: line length of 106 exceeds 100 columns
>
> Which one are you referring to?

The first one, I think.

>
> I've fixed the braces one.
>
> The line length one if changed leads to another warning "warning: quoted
> string split across lines".

Yes we prefer to have long lines than split strings.

Regards,
Simon