[PATCH 1/4] mmc: arm_pl180_mmci: Don't bind to all arm, primecell devices

[Patrice CHOTARD]

Hi Stephan

On 7/6/21 4:54 PM, Stephan Gerhold wrote:
> The arm,primecell compatible is used for lots of different types
> of devices, e.g. I2C, SPI, coresight, ... We really should not bind
> the MMC driver to all of them.
> 
> Looking through the device trees in U-Boot there seems to be always
> a second compatible string for the pl180 device, either arm,pl180
> (already listed) or arm,pl18x. Add the "arm,pl18x" compatible to the
> list but remove the generic "arm,primecell".
> 
> Note that on Linux these compatibles cannot be found in drivers
> because AMBA/primecell devices are matched based on their peripheral ID
> instead of the compatible.
> 
> This fixes the following error messages when booting the ST-Ericsson
> U8500 "stemmy" board with the arm_pl180_mmci driver enabled:
> 
>   MMC:   ptm at 801ae000 - probe failed: -38
>   ptm at 801af000 - probe failed: -38
>   funnel at 801a6000 - probe failed: -38
>   tpiu at 80190000 - probe failed: -38
>   etb at 801a4000 - probe failed: -38
> 
> Cc: Patrice Chotard <patrice.chotard at st.com>
> Fixes: 6f41d1a17e20 ("mmc: arm_pl180_mmci: Sync compatible with kernel")
> Signed-off-by: Stephan Gerhold <stephan at gerhold.net>
> ---
> 
>  drivers/mmc/arm_pl180_mmci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/arm_pl180_mmci.c b/drivers/mmc/arm_pl180_mmci.c
> index b2d1b4f9aa..5d1ee64356 100644
> --- a/drivers/mmc/arm_pl180_mmci.c
> +++ b/drivers/mmc/arm_pl180_mmci.c
> @@ -539,7 +539,7 @@ static int arm_pl180_mmc_of_to_plat(struct udevice *dev)
>  
>  static const struct udevice_id arm_pl180_mmc_match[] = {
>  	{ .compatible = "arm,pl180" },
> -	{ .compatible = "arm,primecell" },
> +	{ .compatible = "arm,pl18x" },
>  	{ /* sentinel */ }
>  };
>  
> 


Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>
Tested-by: Patrice Chotard <patrice.chotard at foss.st.com> on stm32f769-disco

Thanks
Patrice