[PATCH u-boot-mvebu 00/31] kwboot / kwbimage improvements

[Stefan Roese]

Hi Marek & Pali,

On 08.07.21 19:30, Marek Behún wrote:
> Hi Stefan and others,
> 
> this is a series of improvements to kwboot, kwbimage and mvebu.
> 
> The main goal of this series is to correctly use BootROM's code
> for loading U-Boot from NOR / NAND: currently only SPL is read by
> BootROM and the main U-Boot is read by SPL. By using BootROM to also
> load main U-Boot we can reduce the size of SPL image, since it does
> not need to contain code for reading NOR / NAND.

Before going into a review of the patches, let me ask about the
motivation of this patchset. Is the reduction of the SPL image size the
main motivation for this series? Or did you experiece some problems
with the SPL code for U-Boot proper loading?

BTW: This patch / mail subject "kwboot / kwbimage improvements" does
not really match its content AFAIU. Here, the SPL returns always back
to the BootROM for U-Boot proper loading part is missing. Or do I
misunderstand something?

BTW2: Could you please list the affected MVEBU SoC's that are affected
by this series so that this is clear?

> Before merging, this series should be tested on as many relevant
> boards as possible.

I fully agree. I very much welcome any "Tested-by" tags and reviews
from others.

Thanks,
Stefan

> Marek & Pali
> 
> Marek Behún (2):
>    tools: kwbimage: Add constant for SDIO bootfrom
>    tools: kwbimage: Cosmetic fix - remove redundant space character
> 
> Pali Rohár (29):
>    tools: kwbimage: Fix compilation without CONFIG_SYS_U_BOOT_OFFS
>    tools: kwbimage: Simplify aligning and calculating checksum
>    tools: kwbimage: Align SPI and NAND images to 256 bytes
>    tools: kwbimage: Fix generation of SATA, SDIO and PCIe images
>    tools: kwbimage: Don't crash when binary file name does not contain
>      '/'
>    tools: kwbimage: Fix check for v0 extended header checksum
>    tools: kwbimage: Validate extended headers of v1 images
>    tools: kwbimage: Validate data checksum of v1 images
>    tools: kwbimage: Print size of binary header in
>      kwbimage_print_header()
>    tools: kwboot: Fix wrong parameter passed to read()
>    tools: kwboot: Fix restoring terminal
>    tools: kwboot: Print trailing newline after terminal is terminated
>    tools: kwboot: Cosmetic fix - add missing curly brackets
>    tools: kwboot: Check for v1 header size
>    tools: kwbimage: Use -a parameter (load address) for v1 images
>    arm: mvebu: Fix return_to_bootrom()
>    arm: mvebu: Mark return_to_bootrom() as a noreturn function
>    arm: mvebu: Implement return_to_bootrom() via U-Boot's SPL framework
>    arm: mvebu: Use U-Boot's SPL BootROM framework for booting from
>      NAND/UART
>    arm: mvebu: Always use BootROM for loading the rest of U-Boot's binary
>    arm: mvebu: gdsys: Remove custom spl_board_init()
>    arm: mvebu: Remove legacy U-Boot header from kwbimage v1 files
>    tools: kwbimage: Remove v1 kwbimage SPL padding to
>      CONFIG_SYS_U_BOOT_OFFS bytes
>    arm: mvebu: Remove unused macro CONFIG_SYS_U_BOOT_OFFS
>    tools: kwbimage: Add support for more BINARY headers
>    tools: kwbimage: Don't parse PAYLOAD keyword
>    tools: kwbimage: Add support for DATA command also for v1 images
>    tools: kwbimage: Add support for a new DATA_DELAY command
>    tools: kwbimage: Do not hide usage of secure header under
>      CONFIG_ARMADA_38X
> 
>   Makefile                               |   2 +-
>   arch/arm/mach-mvebu/Kconfig            |  16 +-
>   arch/arm/mach-mvebu/include/mach/cpu.h |   2 +-
>   arch/arm/mach-mvebu/lowlevel_spl.S     |   3 +-
>   arch/arm/mach-mvebu/spl.c              |  90 +------
>   board/gdsys/a38x/Makefile              |   2 +-
>   board/gdsys/a38x/spl.c                 |  20 --
>   include/configs/clearfog.h             |   6 +-
>   include/configs/controlcenterdc.h      |   8 +-
>   include/configs/db-88f6720.h           |   3 -
>   include/configs/db-88f6820-amc.h       |   5 -
>   include/configs/db-88f6820-gp.h        |   6 -
>   include/configs/db-mv784mp-gp.h        |   3 -
>   include/configs/ds414.h                |   5 -
>   include/configs/helios4.h              |   6 +-
>   include/configs/theadorable.h          |   3 -
>   include/configs/turris_omnia.h         |   6 -
>   include/configs/x530.h                 |   3 -
>   scripts/config_whitelist.txt           |   1 -
>   tools/Makefile                         |   8 -
>   tools/kwbimage.c                       | 339 +++++++++++++++++--------
>   tools/kwbimage.h                       |  30 ++-
>   tools/kwboot.c                         |  14 +-
>   23 files changed, 296 insertions(+), 285 deletions(-)
>   delete mode 100644 board/gdsys/a38x/spl.c
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de