[PATCH u-boot-mvebu 00/31] kwboot / kwbimage improvements

[Chris Packham]

On Fri, Jul 9, 2021 at 5:30 AM Marek Behún <marek.behun at nic.cz> wrote:
>
> Hi Stefan and others,
>
> this is a series of improvements to kwboot, kwbimage and mvebu.
>
> The main goal of this series is to correctly use BootROM's code
> for loading U-Boot from NOR / NAND: currently only SPL is read by
> BootROM and the main U-Boot is read by SPL. By using BootROM to also
> load main U-Boot we can reduce the size of SPL image, since it does
> not need to contain code for reading NOR / NAND.
>
> Before merging, this series should be tested on as many relevant
> boards as possible.

I've given the series a look over. Aside from a couple of typos in one
commit message which I replied to, the rest looked pretty good.

Review-by: Chris Packham <judge.packham at gmail.com>

For DB-88f6820-AMC and x530

Tested-by: Chris Packham <judge.packham at gmail.com>

>
> Marek & Pali
>
> Marek Behún (2):
>   tools: kwbimage: Add constant for SDIO bootfrom
>   tools: kwbimage: Cosmetic fix - remove redundant space character
>
> Pali Rohár (29):
>   tools: kwbimage: Fix compilation without CONFIG_SYS_U_BOOT_OFFS
>   tools: kwbimage: Simplify aligning and calculating checksum
>   tools: kwbimage: Align SPI and NAND images to 256 bytes
>   tools: kwbimage: Fix generation of SATA, SDIO and PCIe images
>   tools: kwbimage: Don't crash when binary file name does not contain
>     '/'
>   tools: kwbimage: Fix check for v0 extended header checksum
>   tools: kwbimage: Validate extended headers of v1 images
>   tools: kwbimage: Validate data checksum of v1 images
>   tools: kwbimage: Print size of binary header in
>     kwbimage_print_header()
>   tools: kwboot: Fix wrong parameter passed to read()
>   tools: kwboot: Fix restoring terminal
>   tools: kwboot: Print trailing newline after terminal is terminated
>   tools: kwboot: Cosmetic fix - add missing curly brackets
>   tools: kwboot: Check for v1 header size
>   tools: kwbimage: Use -a parameter (load address) for v1 images
>   arm: mvebu: Fix return_to_bootrom()
>   arm: mvebu: Mark return_to_bootrom() as a noreturn function
>   arm: mvebu: Implement return_to_bootrom() via U-Boot's SPL framework
>   arm: mvebu: Use U-Boot's SPL BootROM framework for booting from
>     NAND/UART
>   arm: mvebu: Always use BootROM for loading the rest of U-Boot's binary
>   arm: mvebu: gdsys: Remove custom spl_board_init()
>   arm: mvebu: Remove legacy U-Boot header from kwbimage v1 files
>   tools: kwbimage: Remove v1 kwbimage SPL padding to
>     CONFIG_SYS_U_BOOT_OFFS bytes
>   arm: mvebu: Remove unused macro CONFIG_SYS_U_BOOT_OFFS
>   tools: kwbimage: Add support for more BINARY headers
>   tools: kwbimage: Don't parse PAYLOAD keyword
>   tools: kwbimage: Add support for DATA command also for v1 images
>   tools: kwbimage: Add support for a new DATA_DELAY command
>   tools: kwbimage: Do not hide usage of secure header under
>     CONFIG_ARMADA_38X
>
>  Makefile                               |   2 +-
>  arch/arm/mach-mvebu/Kconfig            |  16 +-
>  arch/arm/mach-mvebu/include/mach/cpu.h |   2 +-
>  arch/arm/mach-mvebu/lowlevel_spl.S     |   3 +-
>  arch/arm/mach-mvebu/spl.c              |  90 +------
>  board/gdsys/a38x/Makefile              |   2 +-
>  board/gdsys/a38x/spl.c                 |  20 --
>  include/configs/clearfog.h             |   6 +-
>  include/configs/controlcenterdc.h      |   8 +-
>  include/configs/db-88f6720.h           |   3 -
>  include/configs/db-88f6820-amc.h       |   5 -
>  include/configs/db-88f6820-gp.h        |   6 -
>  include/configs/db-mv784mp-gp.h        |   3 -
>  include/configs/ds414.h                |   5 -
>  include/configs/helios4.h              |   6 +-
>  include/configs/theadorable.h          |   3 -
>  include/configs/turris_omnia.h         |   6 -
>  include/configs/x530.h                 |   3 -
>  scripts/config_whitelist.txt           |   1 -
>  tools/Makefile                         |   8 -
>  tools/kwbimage.c                       | 339 +++++++++++++++++--------
>  tools/kwbimage.h                       |  30 ++-
>  tools/kwboot.c                         |  14 +-
>  23 files changed, 296 insertions(+), 285 deletions(-)
>  delete mode 100644 board/gdsys/a38x/spl.c
>
> --
> 2.31.1
>