[PATCH u-boot-mvebu v2] arm: mvebu: armada-3720: remove unused config option

[Stefan Roese]

On 09.07.21 17:40, Marek Behún wrote:
> The config option CONFIG_DEBUG_UART_CLOCK is not used by Armada 3720's
> serial driver (it wasn't even before the recent update of that driver).
> 
> Even if it was used, the value was incorrect (the frequency of the clock
> is 25 MHz, not 25.8048 MHz).
> 
> Remove it from config files and set the default value to 0.
> 
> Signed-off-by: Marek Behún <marek.behun at nic.cz>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Pali Rohár <pali at kernel.org>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
> Change since v1:
> - we also need to specify a default value for this variable in Kconfig,
>    otherwise the make command will ask for a value. Use 0 for the default
>    value since it is not used
> - updated commit message
> ---
>   configs/mvebu_db-88f3720_defconfig          | 1 -
>   configs/mvebu_espressobin-88f3720_defconfig | 1 -
>   configs/turris_mox_defconfig                | 1 -
>   configs/uDPU_defconfig                      | 1 -
>   drivers/serial/Kconfig                      | 1 +
>   5 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/configs/mvebu_db-88f3720_defconfig b/configs/mvebu_db-88f3720_defconfig
> index c9935da102..ff4668e837 100644
> --- a/configs/mvebu_db-88f3720_defconfig
> +++ b/configs/mvebu_db-88f3720_defconfig
> @@ -11,7 +11,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
>   CONFIG_DM_GPIO=y
>   CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
>   CONFIG_DEBUG_UART_BASE=0xd0012000
> -CONFIG_DEBUG_UART_CLOCK=25804800
>   CONFIG_DEBUG_UART=y
>   CONFIG_AHCI=y
>   CONFIG_DISTRO_DEFAULTS=y
> diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig
> index 157a4b7cb2..dc199cfe50 100644
> --- a/configs/mvebu_espressobin-88f3720_defconfig
> +++ b/configs/mvebu_espressobin-88f3720_defconfig
> @@ -11,7 +11,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
>   CONFIG_DM_GPIO=y
>   CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
>   CONFIG_DEBUG_UART_BASE=0xd0012000
> -CONFIG_DEBUG_UART_CLOCK=25804800
>   CONFIG_DEBUG_UART=y
>   CONFIG_AHCI=y
>   CONFIG_DISTRO_DEFAULTS=y
> diff --git a/configs/turris_mox_defconfig b/configs/turris_mox_defconfig
> index 2c6f4938db..b3458acb98 100644
> --- a/configs/turris_mox_defconfig
> +++ b/configs/turris_mox_defconfig
> @@ -11,7 +11,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
>   CONFIG_DM_GPIO=y
>   CONFIG_DEFAULT_DEVICE_TREE="armada-3720-turris-mox"
>   CONFIG_DEBUG_UART_BASE=0xd0012000
> -CONFIG_DEBUG_UART_CLOCK=25804800
>   CONFIG_DEBUG_UART=y
>   CONFIG_OF_BOARD_FIXUP=y
>   CONFIG_DISTRO_DEFAULTS=y
> diff --git a/configs/uDPU_defconfig b/configs/uDPU_defconfig
> index cdf6b2274c..649248d74d 100644
> --- a/configs/uDPU_defconfig
> +++ b/configs/uDPU_defconfig
> @@ -10,7 +10,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
>   CONFIG_DM_GPIO=y
>   CONFIG_DEFAULT_DEVICE_TREE="armada-3720-uDPU"
>   CONFIG_DEBUG_UART_BASE=0xd0012000
> -CONFIG_DEBUG_UART_CLOCK=25804800
>   CONFIG_DEBUG_UART=y
>   CONFIG_AHCI=y
>   CONFIG_DISTRO_DEFAULTS=y
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index 961e3fb031..93348c0929 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -443,6 +443,7 @@ config DEBUG_UART_CLOCK
>   	int "UART input clock"
>   	depends on DEBUG_UART
>   	default 0 if DEBUG_UART_SANDBOX
> +	default 0 if DEBUG_MVEBU_A3700_UART
>   	help
>   	  The UART input clock determines the speed of the internal UART
>   	  circuitry. The baud rate is derived from this by dividing the input
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de