[PATCH] board: sifive: drop stuff related to unmatched revision 1

[David Abdurachmanov]

On Wed, Jul 14, 2021 at 2:22 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Zong,
>
> On Fri, Jul 9, 2021 at 4:06 PM Zong Li <zong.li at sifive.com> wrote:
> >
> > This patch reverts the following commits:
> >  - 4b4159d0f3 ("riscv: dts: add dts for unmatched rev1")
> >  - ffe9a394df ("board: sifive: support spl multi-dtb on unmatched board")
> >
> > We won't plan to support unmatched that the revision below 3 in u-boot,
> > so they can be dropped because they might be useless.
> >
> > Signed-off-by: Zong Li <zong.li at sifive.com>
> > Suggested-by: David Abdurachmanov <david.abdurachmanov at sifive.com>
> > ---
> >  arch/riscv/dts/Makefile                       |    2 +-
> >  .../fu740-hifive-unmatched-a00-ddr-rev1.dtsi  | 1489 -----------------
> >  .../dts/hifive-unmatched-a00-rev1-u-boot.dtsi |    7 -
> >  arch/riscv/dts/hifive-unmatched-a00-rev1.dts  |    4 -
> >  board/sifive/unmatched/spl.c                  |   28 +-
> >  configs/sifive_unmatched_defconfig            |    4 -
> >  6 files changed, 3 insertions(+), 1531 deletions(-)
> >  delete mode 100644 arch/riscv/dts/fu740-hifive-unmatched-a00-ddr-rev1.dtsi
> >  delete mode 100644 arch/riscv/dts/hifive-unmatched-a00-rev1-u-boot.dtsi
> >  delete mode 100644 arch/riscv/dts/hifive-unmatched-a00-rev1.dts
>
> How do we tell boards at our hands whether it is rev1 board?

The boards from Crowd Supply and Mourser are 3B0 boards. That's at the
end of the assembly number (sticker on the board next to DIP and RTC
battery).
I2C EEPROM driver will print information (incl. PCB revision, e.g. 3).

You cannot buy any older revision. There are some 3A0 (you might have
one if you received it as an early access software ecosystem partner).
There are only minor changes between these boards and do not affect,
e.g. device tree. Boath boards will report PCB revision at 3.


>
> Are all patches in SiFive SDK upstreamed in current u-boot/master?

Not yet.

E.g. "[PATCH 0/2] board: sifive: unmatched: reset multiple devices in
SPL" I believe is not merged yet.

There might be some other things (I would need to check), e.g. LED
colors for bootstage indicator.

Cheers,
david

>
> Regards,
> Bin