[PATCH] drivers: watchdog: wdt-uclass: Use IS_ENABLED for WATCHDOG_AUTOSTART

Tim Harvey tharvey at gateworks.com
Thu Jul 15 00:42:27 CEST 2021


On Fri, Jun 18, 2021 at 4:14 AM Teresa Remmet <t.remmet at phytec.de> wrote:
>
> There is no separate SPL/TPL config for WATCHDOG_AUTOSTART.
> So use IS_ENABLED instead of CONFIG_IS_ENABLED to make watchdog
> working in spl again.
>
> Signed-off-by: Teresa Remmet <t.remmet at phytec.de>
> ---
>  drivers/watchdog/wdt-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c
> index 268713529604..f113a65fc187 100644
> --- a/drivers/watchdog/wdt-uclass.c
> +++ b/drivers/watchdog/wdt-uclass.c
> @@ -51,7 +51,7 @@ int initr_watchdog(void)
>                                                     4 * reset_period) / 4;
>         }
>
> -       if (!CONFIG_IS_ENABLED(WATCHDOG_AUTOSTART)) {
> +       if (!IS_ENABLED(CONFIG_WATCHDOG_AUTOSTART)) {
>                 printf("WDT:   Not starting\n");
>                 return 0;
>         }
> --
> 2.25.1
>

Maybe add a 'Fixes: 830d29ac3721 ("watchdog: Allow to use CONFIG_WDT
without starting watchdog")' to the commit message?

I'm more interested in just someone picking this up as without it SPL
watchdog is broken.

Tim


More information about the U-Boot mailing list