[PATCH u-boot-mvebu 11/31] tools: kwboot: Fix wrong parameter passed to read()

[Stefan Roese]

On 08.07.21 19:30, Marek Behún wrote:
> From: Pali Rohár <pali at kernel.org>
> 
> The 'buf' is a pointer and '_buf' is the array itself.
> Therefore we should pass sizeof(_buf) instead of sizeof(buf) to read().
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>
> Reviewed-by: Marek Behún <marek.behun at nic.cz>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   tools/kwboot.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index 4be094c9c8..2edeb5a371 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -471,7 +471,7 @@ kwboot_term_pipe(int in, int out, char *quit, int *s)
>   	ssize_t nin, nout;
>   	char _buf[128], *buf = _buf;
>   
> -	nin = read(in, buf, sizeof(buf));
> +	nin = read(in, buf, sizeof(_buf));
>   	if (nin <= 0)
>   		return -1;
>   
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de