[PATCH u-boot-mvebu 12/31] tools: kwboot: Fix restoring terminal

[Stefan Roese]

On 08.07.21 19:30, Marek Behún wrote:
> From: Pali Rohár <pali at kernel.org>
> 
> Call tcsetattr() only if the file descriptor is valid. It may be
> invalidated by previous lines (if it is not a tty descriptor).
> 
> Signed-off-by: Pali Rohár <pali at kernel.org>
> Reviewed-by: Marek Behún <marek.behun at nic.cz>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   tools/kwboot.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index 2edeb5a371..7e8bf21d37 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -564,7 +564,8 @@ kwboot_terminal(int tty)
>   		}
>   	} while (quit[s] != 0);
>   
> -	tcsetattr(in, TCSANOW, &otio);
> +	if (in >= 0)
> +		tcsetattr(in, TCSANOW, &otio);
>   out:
>   	return rc;
>   }
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de