[PATCH 15/17] i2c: Create a new Kconfig for I2C

Heiko Schocher hs at denx.de
Mon Jul 19 06:06:36 CEST 2021


Hello Simon,

On 11.07.21 05:14, Simon Glass wrote:
> At present we have CONFIG_SPL_I2C but not CONFIG_I2C. The reason
> CONFIG_I2C is not strictly necessary is that:
> 
> a) We have CONFIG_SYS_I2C_LEGACY and CONFIG_DM_I2C for the two possible
>    i2c stacks
> b) In U-Boot proper, we always build drivers/i2c/ regardless of the
>    options
> 
> Still, it is better to have CONFIG_I2C - it makes U-Boot proper similar to
> SPL/TPL, so we can (in a future commit) simplify the Makefile rules.
> 
> Enable it by default, since as above, we have separate options
> (SYS_I2C_LEGACY and DM_I2C) to control whether it is 'really' enabled.
> 
> Once we have migrated I2C to driver model, we can drop SYS_I2C_LEGACY and
> make DM_I2C become I2C. For now, this lets us simplify the Makefile rules.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
>  drivers/i2c/Kconfig | 26 ++++++++++++++++++++++++--
>  1 file changed, 24 insertions(+), 2 deletions(-)


Reviewed-by: Heiko Schocher <hs at denx.de>

Thanks!

bye,
Heiko

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list