[PATCH u-boot-mvebu v2 24/41] tools: kwboot: Fix restoring terminal

Marek Behún marek.behun at nic.cz
Mon Jul 19 14:20:47 CEST 2021


From: Pali Rohár <pali at kernel.org>

Call tcsetattr() only if the file descriptor is valid. It may be
invalidated by previous lines (if it is not a tty descriptor).

Signed-off-by: Pali Rohár <pali at kernel.org>
Reviewed-by: Marek Behún <marek.behun at nic.cz>
Reviewed-by: Stefan Roese <sr at denx.de>
Reviewed-by: Chris Packham <judge.packham at gmail.com>
Tested-by: Chris Packham <judge.packham at gmail.com>
---
 tools/kwboot.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/kwboot.c b/tools/kwboot.c
index 1ba5ded5d3..7fa742d84c 100644
--- a/tools/kwboot.c
+++ b/tools/kwboot.c
@@ -558,7 +558,8 @@ kwboot_terminal(int tty)
 		}
 	} while (quit[s] != 0);
 
-	tcsetattr(in, TCSANOW, &otio);
+	if (in >= 0)
+		tcsetattr(in, TCSANOW, &otio);
 out:
 	return rc;
 }
-- 
2.31.1



More information about the U-Boot mailing list