[PATCH v3 0/5] Add SIMATIC IOT2050 board support
Jan Kiszka
jan.kiszka at siemens.com
Tue Jul 20 09:24:49 CEST 2021
On 15.07.21 08:35, Lokesh Vutla wrote:
> Hi Jan,
>
> On 14/07/21 3:09 pm, Jan Kiszka wrote:
>> On 14.07.21 11:29, Lokesh Vutla wrote:
>>> Hi Jan,
>>>
>>> On 12/06/21 1:12 am, Jan Kiszka wrote:
>>>> This is the baseline support for the SIMATIC IOT2050 devices.
>>>>
>>>> Changes in v3:
>>>> - rebased
>>>> - addressed several checkpatch warnings
>>>> - a few #ifdef -> IS_ENABLED conversions
>>>> - comment marker for SPDK identifier in .S file
>>>> - trailing whitespaces
>>>> - factored out rti_wdt_load_fw (less #ifdef)
>>>
>>> I see that there is no conclusion yet for the Watchdog firmware support. But
>>> that can be split out from this series IMO. Can you repost with basic support so
>>> that I can merge the series. Watchdog support can be dealt separately.
>>
>> I will eventually look again into that loading topic, but I would also
>> consider that non-critical to merge it this way first and cleanup later
>> if it actually turns out to be solvable in an equivalent way (result is
>> part of u-boot proper image) via binman. Even the configuration
>> interface may stay the same.
>>
>> If you still have concerns, skip patch 4 and 5 - though that would
>> affect an increasing demand of our users for this important feature.
>
> First 3 patches of the series throws a build error for me:
> https://source.denx.de/u-boot/custodians/u-boot-ti/-/jobs/292183
>
> Can you take a look?
>
Thanks, found and fixed - but now I'm facing a boot regression over
current master. Will have to bisect this, if this is related to some
config switch we are missing now or rather a real issue in the current tree.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
More information about the U-Boot
mailing list