[PATCH u-boot-mvebu v3 23/41] tools: kwboot: Fix wrong parameter passed to read()

Marek Behún marek.behun at nic.cz
Fri Jul 23 11:14:17 CEST 2021


From: Pali Rohár <pali at kernel.org>

The 'buf' variable is a pointer and '_buf' is the array itself.
Therefore we should pass sizeof(_buf) instead of sizeof(buf) to read().

Signed-off-by: Pali Rohár <pali at kernel.org>
Reviewed-by: Marek Behún <marek.behun at nic.cz>
Reviewed-by: Stefan Roese <sr at denx.de>
Reviewed-by: Chris Packham <judge.packham at gmail.com>
Tested-by: Chris Packham <judge.packham at gmail.com>
---
 tools/kwboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/kwboot.c b/tools/kwboot.c
index 2683e5360c..1ba5ded5d3 100644
--- a/tools/kwboot.c
+++ b/tools/kwboot.c
@@ -465,7 +465,7 @@ kwboot_term_pipe(int in, int out, char *quit, int *s)
 	ssize_t nin, nout;
 	char _buf[128], *buf = _buf;
 
-	nin = read(in, buf, sizeof(buf));
+	nin = read(in, buf, sizeof(_buf));
 	if (nin <= 0)
 		return -1;
 
-- 
2.31.1



More information about the U-Boot mailing list