[PATCH v3 06/14] common: fit: Use hash.c to call CRC/SHA function

Tom Rini trini at konsulko.com
Sat Jul 24 14:57:20 CEST 2021


On Tue, Jul 20, 2021 at 02:38:31PM +0800, Chia-Wei Wang wrote:

> From: Joel Stanley <joel at jms.id.au>
> 
> Currently the FIT verification calls directly into
> SW implemented functions to get a CRC/SHA/MD5 hash.
> 
> This patch removes duplcated algorithm lookup and use
> hash_lookup_algo to get the hashing function with HW
> accelearation supported if configured.
> 
> The MD5 direct call remains as it is not included in
> the hash lookup table of hash.c.
> 
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> Signed-off-by: Chia-Wei Wang <chiawei_wang at aspeedtech.com>

While this is a good idea, there's some required prep work.  At least
the following platforms don't compile due to this patch:
ls1046ardb_qspi imx8mm_beacon imx8mn_beacon imx8mn_beacon_2g
imx8mm-icore-mx8mm-ctouch2 imx8mm-icore-mx8mm-edimm2.2 imx8mm_evk
imx8mn_ddr4_evk imx8mn_evk imx8mp_evk imx8mq_evk imx8mm_venice
imx8mq_phanbell phycore-imx8mm phycore-imx8mp pico-imx8mq verdin-imx8mm
mt8183_pumpkin mt8516_pumpkin mscc_jr2 mscc_luton mscc_ocelot
mscc_serval mscc_servalt mt7620_mt7530_rfb mt7620_rfb mt7628_rfb

Which is likely due to cases where HASH or SPL_HASH_SUPPORT are not
being selected as it was not previously required.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210724/db9528ce/attachment.sig>


More information about the U-Boot mailing list