[PATCH v2 8/8] mmc: zynq_sdhci: Use set_control_reg from sdhci.c

Ashok Reddy Soma ashokred at xilinx.com
Tue Jul 27 14:50:56 CEST 2021


Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Sorry, Forgot to add Reviewed-by:
https://patchwork.ozlabs.org/project/uboot/patch/20210724081009.15761-8-ashok.reddy.soma@xilinx.com/ 

Thanks,
Ashok

> -----Original Message-----
> From: Ashok Reddy Soma <ashok.reddy.soma at xilinx.com>
> Sent: Tuesday, July 27, 2021 6:07 PM
> To: u-boot at lists.denx.de
> Cc: peng.fan at nxp.com; jh80.chung at samsung.com; faiz_abbas at ti.com;
> sjg at chromium.org; michael at walle.cc; git <git at xilinx.com>;
> monstr at monstr.eu; somaashokreddy at gmail.com; Ashok Reddy Soma
> <ashokred at xilinx.com>
> Subject: [PATCH v2 8/8] mmc: zynq_sdhci: Use set_control_reg from sdhci.c
> 
> Since set_control_reg is available in sdhci.c, use it and remove
> arasan_sdhci_set_control_reg().
> 
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at xilinx.com>
> ---
> 
> (no changes since v1)
> 
>  drivers/mmc/zynq_sdhci.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
> 
> diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c index
> e71ba4eee0..4becd8c7ba 100644
> --- a/drivers/mmc/zynq_sdhci.c
> +++ b/drivers/mmc/zynq_sdhci.c
> @@ -603,29 +603,10 @@ static void arasan_dt_parse_clk_phases(struct
> udevice *dev)
>  				 "clk-phase-mmc-hs400");
>  }
> 
> -static void arasan_sdhci_set_control_reg(struct sdhci_host *host) -{
> -	struct mmc *mmc = (struct mmc *)host->mmc;
> -	u32 reg;
> -
> -	if (!IS_SD(mmc))
> -		return;
> -
> -	if (mmc->signal_voltage == MMC_SIGNAL_VOLTAGE_180) {
> -		reg = sdhci_readw(host, SDHCI_HOST_CONTROL2);
> -		reg |= SDHCI_CTRL_VDD_180;
> -		sdhci_writew(host, reg, SDHCI_HOST_CONTROL2);
> -	}
> -
> -	if (mmc->selected_mode > SD_HS &&
> -	    mmc->selected_mode <= MMC_HS_200)
> -		sdhci_set_uhs_timing(host);
> -}
> -
>  static const struct sdhci_ops arasan_ops = {
>  	.platform_execute_tuning	= &arasan_sdhci_execute_tuning,
>  	.set_delay = &arasan_sdhci_set_tapdelay,
> -	.set_control_reg = &arasan_sdhci_set_control_reg,
> +	.set_control_reg = &sdhci_set_control_reg,
>  };
>  #endif
> 
> --
> 2.17.1



More information about the U-Boot mailing list