[PATCH v1] imx: mkimage_fit_atf: replace @ with hyphen

Tim Harvey tharvey at gateworks.com
Tue Jul 27 23:53:13 CEST 2021


On Tue, Jul 27, 2021 at 12:17 PM Heiko Thiery <heiko.thiery at gmail.com> wrote:
>
> Hi all,
>
> Am Mi., 5. Mai 2021 um 15:30 Uhr schrieb ZHIZHIKIN Andrey
> <andrey.zhizhikin at leica-geosystems.com>:
> >
> > Hello Oliver,
> >
> > > -----Original Message-----
> > > From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Oliver Graute
> > > Sent: Wednesday, May 5, 2021 2:01 PM
> > > To: sbabic at denx.de
> > > Cc: festevam at gmail.com; peng.fan at nxp.com;
> > > oliver.graute at kococonnector.com; u-boot at lists.denx.de; Simon Glass
> > > <sjg at chromium.org>; uboot-imx <uboot-imx at nxp.com>
> > > Subject: [PATCH v1] imx: mkimage_fit_atf: replace @ with hyphen
> > >
> > >
> > > Unit addresses are not allowed anymore in a FIT image since
> > >
> > > commit 3f04db891a35 ("image: Check for unit addresses in FITs")
> > >
> > > This caused this error on mkimage creation:
> > >
> > > ./tools/mkimage: verify_header failed for FIT Image support with exit code 1
> > > Makefile:1393: recipe for target 'u-boot.itb' failed
> > > make: *** [u-boot.itb] Error 1
>
> This error is still present in the current master branch and the
> target "flash.bin" does not not build anymore for the
> imx8mq_evk_defconfig.
>
> Any thoughts to apply this patch to master?
>

Heiko,

I just ran into this failure as well with imx8mm_venice_defconfig
which I haven't moved to binman yet.

With respect to moving to binman, I'm all for it but I'm wondering why
other boards have elected to move from a monolithic flash.bin
including the SPL and u-boot.itb pre-binman to post-binman where
flash.bin is just the SPL. I'm not sure why users should be hit with a
change like that... why are people not having binman produce a
flash.bin that was equivalent to pre-binman?

Best regards,

Tim


More information about the U-Boot mailing list