[PATCH v2 2/3] arm: Add an __image_copy_start symbol for ARMv8

[Simon Glass]

Hi Tim,

On Mon, 26 Jul 2021 at 12:20, Tim Harvey <tharvey at gateworks.com> wrote:
>
> On Sun, Jul 25, 2021 at 9:54 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > This symbol is needed for binman to locate the start of the image. Add it.
> >
> > Note: the existing line to bring in the .__image_copy_start symbol does
> > not appear to do anything.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > Changes in v2:
> > - Add new patch to add an __image_copy_start symbol for ARMv8
> >
> >  arch/arm/cpu/armv8/u-boot-spl.lds | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/cpu/armv8/u-boot-spl.lds b/arch/arm/cpu/armv8/u-boot-spl.lds
> > index 9edb662b094..2827a07590d 100644
> > --- a/arch/arm/cpu/armv8/u-boot-spl.lds
> > +++ b/arch/arm/cpu/armv8/u-boot-spl.lds
> > @@ -22,6 +22,7 @@ ENTRY(_start)
> >  SECTIONS
> >  {
> >         .text : {
> > +               __image_copy_start = .;
> >                 . = ALIGN(8);
> >                 *(.__image_copy_start)
> >                 CPUDIR/start.o (.text*)
> > --
> > 2.32.0.432.gabb21c7263-goog
> >
>
> Sould the '*(.__image_copy_start)' be removed?
>
> I'll admit that I'm not very knowledgable when it comes to linker
> files. I did verify removing it boots fine.

I did look around for symbols in that section and could not find any,
but I'm not 100% sure.

Regards,
SImon