[[PATCH] colibri_imx6: add board_fit_config_name_match to support FIT in SPL

Ming Liu liu.ming50 at gmail.com
Tue Jun 1 17:58:38 CEST 2021


Hi, Sean:

Thanks for the comments, please see my answers as follows:

> Please use an errno.

Seems all other board are using '0' and '-1' as return value of
board_fit_config_name_match, shouldn't we keep consistent with them?

> Do you need to match "imx6-colibri", or could you use the default config?

I think so since imx6-colibri.its is the only present DTS file for this
board.

//Ming Liu




Sean Anderson <seanga2 at gmail.com> 於 2021年5月31日 週一 下午4:36寫道:

> On 5/31/21 3:06 AM, liu.ming50 at gmail.com wrote:
> > From: Ming Liu <liu.ming50 at gmail.com>
> >
> > Only one dtb is currently supported, so match with imx6-colibri.
> >
> > Signed-off-by: Ming Liu <liu.ming50 at gmail.com>
> > ---
> >   board/toradex/colibri_imx6/colibri_imx6.c | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> >
> > diff --git a/board/toradex/colibri_imx6/colibri_imx6.c
> b/board/toradex/colibri_imx6/colibri_imx6.c
> > index c0e7754469..587d92a8e9 100644
> > --- a/board/toradex/colibri_imx6/colibri_imx6.c
> > +++ b/board/toradex/colibri_imx6/colibri_imx6.c
> > @@ -1081,6 +1081,16 @@ void board_init_f(ulong dummy)
> >       board_init_r(NULL, 0);
> >   }
> >
> > +#ifdef CONFIG_SPL_LOAD_FIT
> > +int board_fit_config_name_match(const char *name)
> > +{
> > +     if (!strcmp(name, "imx6-colibri"))
> > +             return 0;
> > +
> > +     return -1;
>
> Please use an errno.
>
> > +}
> > +#endif
> > +
> >   void reset_cpu(void)
> >   {
> >   }
> >
>
> Do you need to match "imx6-colibri", or could you use the default config?
>
> --Sean
>


More information about the U-Boot mailing list