[PATCH] evb_rk3399: add usb ohci definations

[Peter Robinson]

On Wed, Jun 2, 2021 at 3:33 AM Art Nikpal <email2tema at gmail.com> wrote:
>
> > But , evb_rk3399 board does not enable CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC.
>
> yes i know it !
>
> for example some other rk3399 boards have it because (usb 1.1 didnt
> work without ohci on usb2.0 port and not possible to use usb kbd for
> this port )
>
> grep CONFIG_USB_OHCI_GENERIC configs/*3399*
> configs/pinebook-pro-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y
> configs/rock960-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y
> configs/rockpro64-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y
>
> many other boards which used TARGET_EVB_RK3399=y must have  same
> problem (with usb1.1)

The 3 boards you mention above define their own target and don't use
TARGET_EVB_RK3399

> and i think other boards must have possibilities to use
> CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC.

So I think Kever's point was that without defining the following two
options in the appropriate config files your patch has no effect
because the OHCI support isn't actually built for the boards. I
suggest a v2 patch which does that.

CONFIG_USB_OHCI_HCD=y
CONFIG_USB_OHCI_GENERIC=y

Regards,
Peter