[PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error

Patrick Wildt patrick at blueri.se
Fri Jun 4 17:46:42 CEST 2021


Am Fri, Jun 04, 2021 at 04:56:05AM +0000 schrieb Anand Moon:
> Use the generic error number instead of specific error number.
> Changes fix the below error.
> 
> drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_read':
> drivers/pci/pcie_dw_rockchip.c:70:10: error: 'PCIBIOS_UNSUPPORTED'
>                         undeclared (first use in this function)
>    70 |   return PCIBIOS_UNSUPPORTED;
>       |          ^~~~~~~~~~~~~~~~~~~
> drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_write':
> drivers/pci/pcie_dw_rockchip.c:90:10: error: 'PCIBIOS_UNSUPPORTED'
>                         undeclared (first use in this function)
>    90 |   return PCIBIOS_UNSUPPORTED;
>       |          ^~~~~~~~~~~~~~~~~~~
> 
> Cc: Patrick Wildt <patrick at blueri.se>
> Cc: Neil Armstrong <narmstrong at baylibre.com>
> Cc: Kever Yang <kever.yang at rock-chips.com>
> Reviewed-by: Neil Armstrong <narmstrong at baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon at gmail.com>
> ---
> v1: Drop the PCI ERROR MACRO,
> v2: added the Neil review tag.
> ---
> ---
>  drivers/pci/pcie_dw_rockchip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
> index bc22af4230..3ac2434b69 100644
> --- a/drivers/pci/pcie_dw_rockchip.c
> +++ b/drivers/pci/pcie_dw_rockchip.c
> @@ -67,7 +67,7 @@ static int rk_pcie_read(void __iomem *addr, int size, u32 *val)
>  {
>  	if ((uintptr_t)addr & (size - 1)) {
>  		*val = 0;
> -		return PCIBIOS_UNSUPPORTED;
> +		return -EOPNOTSUPP;
>  	}
>  
>  	if (size == 4) {
> @@ -87,7 +87,7 @@ static int rk_pcie_read(void __iomem *addr, int size, u32 *val)
>  static int rk_pcie_write(void __iomem *addr, int size, u32 val)
>  {
>  	if ((uintptr_t)addr & (size - 1))
> -		return PCIBIOS_UNSUPPORTED;
> +		return -EOPNOTSUPP;
>  
>  	if (size == 4)
>  		writel(val, addr);
> -- 
> 2.31.1
> 

Reviewed-by: Patrick Wildt <patrick at blueri.se>


More information about the U-Boot mailing list