[PATCH] arch: cache: cp15: Add mmu_set_region_dcache_behaviour() when SYS_DCACHE_OFF is enable

Patrick DELAUNAY patrick.delaunay at foss.st.com
Fri Jun 4 19:03:54 CEST 2021


Hi Patrice,

On 2/24/21 1:48 PM, Patrice Chotard wrote:
> From: Patrice Chotard <patrice.chotard at st.com>
>
> Fix following compilation issue when SYS_DCACHE_OFF is enable:
> drivers/misc/scmi_agent.c:128: undefined reference to `mmu_set_region_dcache_behaviour'
>
> when SYS_DCACHE_OFF is enable, mmu_set_region_dcache_behaviour() must be
> defined.
>
> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard at foss.st.com>
> ---
>
>   arch/arm/lib/cache-cp15.c | 18 ++++++++++++------
>   1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/lib/cache-cp15.c b/arch/arm/lib/cache-cp15.c
> index 24050e5bdd..f1703ead96 100644
> --- a/arch/arm/lib/cache-cp15.c
> +++ b/arch/arm/lib/cache-cp15.c
> @@ -97,12 +97,6 @@ void mmu_set_region_dcache_behaviour_phys(phys_addr_t start, phys_addr_t phys,
>   	mmu_page_table_flush(startpt, stoppt);
>   }
>   
> -void mmu_set_region_dcache_behaviour(phys_addr_t start, size_t size,
> -				     enum dcache_option option)
> -{
> -	mmu_set_region_dcache_behaviour_phys(start, start, size, option);
> -}
> -
>   __weak void dram_bank_mmu_setup(int bank)
>   {
>   	struct bd_info *bd = gd->bd;
> @@ -314,6 +308,12 @@ int dcache_status(void)
>   {
>   	return 0;					/* always off */
>   }
> +
> +void mmu_set_region_dcache_behaviour(phys_addr_t start, size_t size,
> +				     enum dcache_option option)
> +{
> +}
> +
>   #else
>   void dcache_enable(void)
>   {
> @@ -329,4 +329,10 @@ int dcache_status(void)
>   {
>   	return (get_cr() & CR_C) != 0;
>   }
> +
> +void mmu_set_region_dcache_behaviour(phys_addr_t start, size_t size,
> +				     enum dcache_option option)
> +{
> +	mmu_set_region_dcache_behaviour_phys(start, start, size, option);
> +}
>   #endif


Reviewed-by: Patrick Delaunay <patrick.delaunay at foss.st.com>

Thanks
Patrick



More information about the U-Boot mailing list