[PATCH] tools: Fix default target compile tools in Python tools

Alper Nebi Yasak alpernebiyasak at gmail.com
Mon Jun 7 20:11:37 CEST 2021

In commit 1e4687aa47ed ("binman: Use target-specific tools when
cross-compiling"), a utility function was implemented to get preferred
compilation tools using environment variables like CC and CROSS_COMPILE.
Although it intended to provide custom default tools (same as those in
the global Makefile) when no relevant variables were set (for example
using "gcc" for "cc"), it is only doing so when CROSS_COMPILE is set and
returning the literal name of the tool otherwise.

Remove the check for an empty CROSS_COMPILE, which makes the function
use it as an empty prefix to the custom defaults and return the intended

Fixes: 1e4687aa47ed ("binman: Use target-specific tools when cross-compiling")
Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>

 tools/patman/tools.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/patman/tools.py b/tools/patman/tools.py
index e5f391b7aa9a..ec95a543bd92 100644
--- a/tools/patman/tools.py
+++ b/tools/patman/tools.py
@@ -292,8 +292,6 @@ def GetTargetCompileTool(name, cross_compile=None):
     if cross_compile is None:
         cross_compile = env.get('CROSS_COMPILE', '')
-    if not cross_compile:
-        return name, []
     if name in ('as', 'ar', 'nm', 'ldr', 'strip', 'objcopy', 'objdump'):
         target_name = cross_compile + name

More information about the U-Boot mailing list