[PATCH v2] Revert "mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON to control card clock output"

Jaehoon Chung jh80.chung at samsung.com
Tue Jun 8 04:50:45 CEST 2021


Hi,

On 6/8/21 11:07 AM, Fabio Estevam wrote:
> Hi Haibo,
> 
> On Mon, Jun 7, 2021 at 10:57 PM Bough Chen <haibo.chen at nxp.com> wrote:
> 
>> Hi Fabio,
>>
>> Force clock on did help us fix some issue, like voltage switch for UHS card.
>> According to your commit log, seems this patch affect the booting time, do
>> you mean
>> the API readx_poll_timeout() cost a lot time? Can you show us the detail
>> info about
>> booting time effected by this patch?
> 
> If I revert the patch SPL/U-Boot boot in one second.
> 
> With this patch, it takes around 20 seconds, which is unacceptable.

Is your target success to boot finally after 20sec?
I didn't have target to use fsl_esdhc_imx driver.

If booted after 20sec, how about below code?

#ifdef CONFIG_FSL_ESDHC_IMX_TIMEOUT
#define FSL_ESDHC_IMX_TIMEOUT	CONFIG_FSL_ESDHC_IMX_TIMEOUT
#else
#define FSL_ESDHC_IMX_TIMEOUT 0
#endif


ret = readx_poll_timeout(..., FSL_ESDHC_IMX_TIMEOUT);
if (FSL_ESDHC_IMX_TIMEOUT && ret)
	pr_warn("...");

If there isn't other issue, 

Best Regards,
Jaehoon Chung

> 
> Thanks
> 



More information about the U-Boot mailing list