[PATCH] net: use the same alias stem for ethernet as linux

Ramon Fried rfried.dev at gmail.com
Mon Jun 14 22:55:44 CEST 2021


On Thu, Apr 29, 2021 at 7:10 PM Simon Glass <sjg at chromium.org> wrote:
>
> On Thu, 25 Feb 2021 at 07:51, Michael Walle <michael at walle.cc> wrote:
> >
> > Linux uses the prefix "ethernet" whereas u-boot uses "eth". This is from
> > the linux tree:
> >
> > $ grep "eth[0-9].*=.*&" arch/**/*dts{,i}|wc -l
> > 0
> > $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l
> > 633
> >
> > In u-boot device trees both prefixes are used. Until recently the only
> > user of the ethernet alias was the sandbox test device tree. This
> > changed with commit fc054d563bfb ("net: Introduce DSA class for Ethernet
> > switches"). There, the MAC addresses are inherited based on the devices
> > sequence IDs which is in turn given by the device tree.
> >
> > Before there are more users in u-boot and both worlds will differ even
> > more, rename the alias prefix to "ethernet" to match the linux ones.
> > Also adapt the test cases and rename any old aliases in the u-boot
> > device trees.
> >
> > Cc: David Wu <david.wu at rock-chips.com>
> > Signed-off-by: Michael Walle <michael at walle.cc>
> > ---
> > Vladimir, I didn't do another patch to rename any ethernet aliases to
> > "eth". Though kontron boards contain "ethernetN" aliases, all in tree
> > variants don't make use of it. So there is nothing to be fixed.
> >
> >  arch/arm/dts/fsl-ls1028a-rdb.dts | 12 ++++++------
> >  arch/sandbox/dts/test.dts        | 10 +++++-----
> >  net/eth-uclass.c                 |  4 ++--
> >  test/dm/ofnode.c                 |  2 +-
> >  test/dm/test-fdt.c               |  2 +-
> >  5 files changed, 15 insertions(+), 15 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
Applied to u-boot-net/master, thanks!

Best regards,
Ramon Fried


More information about the U-Boot mailing list