[PATCH] tools: Use a single target-independent config to enable OpenSSL
sjg at chromium.org
Tue Jun 22 21:25:19 CEST 2021
On Tue, 22 Jun 2021 at 08:13, Alex G. <mr.nuke.me at gmail.com> wrote:
> On 6/22/21 8:31 AM, Simon Glass wrote:
> >> +config TOOLS_USE_LIBCRYPTO
> > would HOST_LIBCRYPTO be better?
> I had considered a shorter kconfig such as the above. Does it mean
> (1) The build host has libcrypto available?
> (2) We use the libcrypto on the host?
> (3) There is a libcrypto for the target?
> "tools" is a subset of what we do on the host so it seems more concrete.
> I realize you could read "tools use libcrypto" as a statement rather
> than a question, which would seem odd in kconfig.
This is the sort of thinking that got us the SPL_XXX_SUPPORT :-)
We never use Kconfig options for (1), so far as I know. That would
just produce a build error.
This is not a target Kconfig, so has nothing to do with that.
So clearly the answer to your question is 2. We should aim for
consistency in the Kconfig options.
> As far as having a verb, I thought it to be important because there
> isn't a substantially similar use of Kconfig in u-boot. I didn't want
> the name to be too vague.
I'd prefer to avoid the verb. It just makes it harder to remember and
it isn't as if we could mean that we would do anything else with the
option than use it...
> Hope this clears things up,
More information about the U-Boot