[PATCH v2] board: sl28: add DSA support for variant 2

Michael Walle michael at walle.cc
Wed Jun 30 13:21:29 CEST 2021


Am 2021-06-30 12:34, schrieb Vladimir Oltean:
> On Wed, Jun 30, 2021 at 10:26:57AM +0200, Michael Walle wrote:
>> Can this please go through the net queue?
>> 
>> By chance, I've seen this patch:
>> https://patchwork.ozlabs.org/project/uboot/patch/20210629175317.2607470-5-vladimir.oltean@nxp.com/
>> 
>> Now I'm lucky that I have the following chunk, otherwise the patch 
>> wouldn't
>> work.
>> 
>> +&enetc2 {
>> +	status = "okay";
>> +};
> 
> Why "lucky"? I remember you were pushing this device tree style in the
> first place.

Thats correct, but in u-boot this device was still defaulting to
status = "okay", thus it would have been superfluous to still enable
it in the board dts. And tbh, I don't exactly know why I enabled
it nonetheless. Normally I keep things small ;)

Its not about the change (which is good), but there seems to be
a disconnect between which patches goes through which queue and
you have to be lucky that a (newer) patch doesn't break your patch
which is sitting on another queue to be picked up while the newer
one is already pulled in.

-- 
-michael


More information about the U-Boot mailing list