[Uboot-stm32] [PATCH 2/2] video: dw_mipi_dsi: update log of dphy_enable

Patrice CHOTARD patrice.chotard at foss.st.com
Tue Mar 9 15:22:46 CET 2021


HI Patrick

On 3/4/21 1:14 PM, Patrick Delaunay wrote:
> From: Yannick Fertre <yannick.fertre at foss.st.com>
> 
> The DSI phy can be turned on from the DSI digital interface in
> the dphy_enable() function or from a dedicated DSI phy "wrapper"
> in phy_ops->init() function. If the STM32MP1 case, the wrapper
> is used then the dphy_enable() "warning" traces are not relevant.
> 
> This patch moves these "warning" traces to "debug" traces so
> they are still available for DSI phy based on the digital
> interface in debug logging mode, but not there in normal mode
> for both cases.
> Note: The related Linux kernel driver uses a "debug"
> message too.
> 
> Signed-off-by: Yannick Fertre <yannick.fertre at foss.st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at foss.st.com>
> ---
> 
>  drivers/video/dw_mipi_dsi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/dw_mipi_dsi.c b/drivers/video/dw_mipi_dsi.c
> index a5beed3514..9ae09eec12 100644
> --- a/drivers/video/dw_mipi_dsi.c
> +++ b/drivers/video/dw_mipi_dsi.c
> @@ -721,15 +721,15 @@ static void dw_mipi_dsi_dphy_enable(struct dw_mipi_dsi *dsi)
>  	ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, val,
>  				 val & PHY_LOCK, PHY_STATUS_TIMEOUT_US);
>  	if (ret)
> -		dev_warn(dsi->dsi_host.dev,
> -			 "failed to wait phy lock state\n");
> +		dev_dbg(dsi->dsi_host.dev,
> +			"failed to wait phy lock state\n");
>  
>  	ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS,
>  				 val, val & PHY_STOP_STATE_CLK_LANE,
>  				 PHY_STATUS_TIMEOUT_US);
>  	if (ret)
> -		dev_warn(dsi->dsi_host.dev,
> -			 "failed to wait phy clk lane stop state\n");
> +		dev_dbg(dsi->dsi_host.dev,
> +			"failed to wait phy clk lane stop state\n");
>  }
>  
>  static void dw_mipi_dsi_clear_err(struct dw_mipi_dsi *dsi)
> 

Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>
Thanks
Patrice


More information about the U-Boot mailing list