[PATCH v3] dm: i2c: Add a migration method for I2C

Simon Glass sjg at chromium.org
Thu Mar 25 20:41:42 CET 2021


Hi Tom,

On Fri, 26 Mar 2021 at 08:30, Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Mar 26, 2021 at 08:11:30AM +1300, Simon Glass wrote:
> > Hi Tom,
> >
> > On Fri, 26 Mar 2021 at 08:05, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Fri, Mar 26, 2021 at 06:48:26AM +1300, Simon Glass wrote:
> > > > Hi Tom,
> > > >
> > > > On Fri, 26 Mar 2021 at 04:59, Tom Rini <trini at konsulko.com> wrote:
> > > > >
> > > > > On Thu, Mar 25, 2021 at 01:39:28PM +1300, Simon Glass wrote:
> > > > >
> > > > > > This probably should have been done a while back since it is a core
> > > > > > system. Add a migration deadline of later this year, to catch the
> > > > > > stragglers.
> > > > > >
> > > > > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > > >
> > > > > What boards trigger this warning when done on top of say the
> > > > > WIP/remove-non-AHCI_LIBATA-drivers branch I've pushed to my github or
> > > > > WIP/make-DM_PCI-fatal which has more removals, but I need to cycle back
> > > > > to and finish removing even more boards I suspect.
> > > >
> > > > With us/WIP/make-DM_PCI-fatal it looks like 250.
> > >
> > > Ugh.  Can you link me the CI run please?  I'm curious about which.
> >
> > Sorry, I did it locally
> >
> > https://pastebin.com/Wq8vgtSx
>
> I'm having trouble with that, sorry.  It looks like it's complaining
> about boards that with your series applied locally don't throw up a
> warning about I2C (but do for DM_ETH, which already has a soon
> deadline).

Yes I was just going off the number of migration messages in the
output (using grep).

>
> > > Then we can introduce this warning for v2021.04 (I'll grab it shortly)
> > > and set the deadline of v2022.04 (a year of being loud) and hopefully
> > > things are migrated / otherwise removed before v2024.04 and they get
> > > nuked like we're starting with now on v2019.xx deadlines.
> >
> > Do you mean 2022.04? My view has become that things that haven't been
> > done probably won't be, so we should save ourselves the trouble and
> > cost of maintaining the boards and just remove them now. For example,
> > the Kconfig migration would be in much better shape (although I
> > haven't analysed how much better).
> >
> > Note I sent a series to clean up the warnings, plus add I2C and GPIO,
> > so you should look at that instead of this patch.
>
> Well, lets get some numbers on what boards throw this I2C warning first.
> I did a quick merge of this series and pushed WIP/add-DM_I2C-warning
> right now and I'm doing the before/after build now.

OK.

Regards,
Simon


More information about the U-Boot mailing list