[PATCH v2 04/13] gpio: Introduce CONFIG_ONLY_GENERIC_GPIO to cleanup #ifdefs

Tom Rini trini at konsulko.com
Mon May 3 13:51:44 CEST 2021


On Fri, Apr 30, 2021 at 11:13:45AM -0700, Simon Glass wrote:
> Hi Masami,
> 
> On Thu, 29 Apr 2021 at 20:03, Masami Hiramatsu
> <masami.hiramatsu at linaro.org> wrote:
> >
> > Hi Simon,
> >
> > 2021年4月30日(金) 1:10 Simon Glass <sjg at chromium.org>:
> > >
> > > Hi Masami,
> > >
> > > On Fri, 16 Apr 2021 at 16:38, Masami Hiramatsu
> > > <masami.hiramatsu at linaro.org> wrote:
> > > >
> > > > Many architecture do not have specific asm/arch/gpio.h, so instead
> > > > of adding !defined(CONFIG_ARCH_xxx), introduce CONFIG_ONLY_GENERIC_GPIO
> > >
> > > This seems OK, but I think GPIO_GENERIC_ONLY is a better name, since
> > > it uses the GPIO prefix.
> > >
> > > I would also prefer to have a 'positive' option, but I suspect that
> > > might be a pain to do?
> >
> > Would you mean making it something like CONFIG_GPIO_EXTRA_HEADER ?
> >
> > I think it is also possible. My concern is if I missed any arch which
> > should say y that :P.
> 
> Yes...it's just that negative configs generally cause us pain at some point.

And in terms of catching all of the platforms, you can submit a pull
request in GitHub which will trigger a CI world build and tell you
what's broken :)

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210503/7220088a/attachment.sig>


More information about the U-Boot mailing list