[PATCH v2 04/13] gpio: Introduce CONFIG_ONLY_GENERIC_GPIO to cleanup #ifdefs

Masami Hiramatsu masami.hiramatsu at linaro.org
Thu May 6 04:28:33 CEST 2021


Hi Tom,

2021年5月3日(月) 20:51 Tom Rini <trini at konsulko.com>:
>
> On Fri, Apr 30, 2021 at 11:13:45AM -0700, Simon Glass wrote:
> > Hi Masami,
> >
> > On Thu, 29 Apr 2021 at 20:03, Masami Hiramatsu
> > <masami.hiramatsu at linaro.org> wrote:
> > >
> > > Hi Simon,
> > >
> > > 2021年4月30日(金) 1:10 Simon Glass <sjg at chromium.org>:
> > > >
> > > > Hi Masami,
> > > >
> > > > On Fri, 16 Apr 2021 at 16:38, Masami Hiramatsu
> > > > <masami.hiramatsu at linaro.org> wrote:
> > > > >
> > > > > Many architecture do not have specific asm/arch/gpio.h, so instead
> > > > > of adding !defined(CONFIG_ARCH_xxx), introduce CONFIG_ONLY_GENERIC_GPIO
> > > >
> > > > This seems OK, but I think GPIO_GENERIC_ONLY is a better name, since
> > > > it uses the GPIO prefix.
> > > >
> > > > I would also prefer to have a 'positive' option, but I suspect that
> > > > might be a pain to do?
> > >
> > > Would you mean making it something like CONFIG_GPIO_EXTRA_HEADER ?
> > >
> > > I think it is also possible. My concern is if I missed any arch which
> > > should say y that :P.
> >
> > Yes...it's just that negative configs generally cause us pain at some point.
>
> And in terms of catching all of the platforms, you can submit a pull
> request in GitHub which will trigger a CI world build and tell you
> what's broken :)

OK, let me try it.

Thank you!

>
> --
> Tom



-- 
Masami Hiramatsu


More information about the U-Boot mailing list