[PATCH v2] mmc: Update environment variable with active partition

[Jaehoon Chung]

Hi Reuben,

On 5/10/21 1:38 PM, Reuben Dowle wrote:
> Hi Jaehoon,
> 
>>
>> boot_ack / boot_partition / partition_access are optional variable, not
>> mandatory.
>> And it's confused that different variable is used with same command.
>>
>> I think that it's enough to use "mmc partconf <dev>". Then it's showed which
>> partition is used.
>>
>> If you have to apply this patch,
>>
>> It seems that "mmc partconf <dev> [varname] [boot_ack boot_partition
>> partition_access]" is correct way.
> 
> mmc partconf has two forms currently - one  where you set the values and one where you read the values. It would not make sense to write the environment variable when you are writing the MMC values.
> 
> When setting the values you need 4 parameters (dev + three values to set). In this case all three values are mandatory, and this is not changing.

<dev> is mandatory, and [<boot_ack> <boot_partition> <partition_access>] is optional.
If optional variable will be used, those variables can be mandatory, right?

mmc partconf <dev> is displayed even without other variables.

"mmc partconf <dev> [[varname] | [<boot_ack> <boot_partition> <partition_access>]]" is correct usage for yours.

It means varname or other options variable can be chosen.

Best Regards,
Jaehoon Chung


> 
> When reading the values you currently just need 1 parameter (dev). This patch adds a second optional parameter to store the current active partition.
> 
>>
>> Best Regards,
>> Jaehoon Chung
>>
> ________________________________
> 
> [cid:4RFLogo(Custom)(2)_0f31a7de-6dd6-43cf-bc6a-a097a2b80b69.jpg]
> Reuben Dowle
> Software Architect
> 
> Phone:
> 
> Fax:
> E-Mail:
> Website:
> 
> 
> +64 4 499 6000
> 
> +64 4 473 4447
> reuben.dowle at 4rf.com<mailto:reuben.dowle at 4rf.com>
> https://protect2.fireeye.com/v1/url?k=db8e7728-84154e07-db8ffc67-0cc47a31cdf8-7844d268e34be46e&q=1&e=63fae9b4-9143-4f55-bc4c-1de4d743c505&u=https%3A%2F%2Fwww.4rf.com%2F<https://protect2.fireeye.com/v1/url?k=c6895738-99126e17-c688dc77-0cc47a31cdf8-79a58163574daf40&q=1&e=63fae9b4-9143-4f55-bc4c-1de4d743c505&u=https%3A%2F%2Fwww.4rf.com%2F>
> 
> 
> ________________________________
> 
> [cid:Family_53c410b1-7227-4a5f-9acb-f09bd7617a39.png] <https://protect2.fireeye.com/v1/url?k=96150f08-c98e3627-96148447-0cc47a31cdf8-4901f25b032dcaaf&q=1&e=63fae9b4-9143-4f55-bc4c-1de4d743c505&u=http%3A%2F%2Fwww.4rf.com%2Fnews%2Fevents>
> 
> ________________________________
> The information in this email communication (inclusive of attachments) is confidential to 4RF Limited and the intended recipient(s). If you are not the intended recipient(s), please note that any use, disclosure, distribution or copying of this information or any part thereof is strictly prohibited and that the author accepts no liability for the consequences of any action taken on the basis of the information provided. If you have received this email in error, please notify the sender immediately by return email and then delete all instances of this email from your system. 4RF Limited will not accept responsibility for any consequences associated with the use of this email (including, but not limited to, damages sustained as a result of any viruses and/or any action or lack of action taken in reliance on it).
>