[PATCH v2 05/16] reset: Avoid a warning in devm_reset_bulk_get_by_node()

Simon Glass sjg at chromium.org
Fri May 14 03:39:21 CEST 2021

The devres_alloc() function is intended to avoid the need for freeing
memory, although in practice it may not be enabled, thus leading to a true

Nevertheless this is intended. Add a comment to explain this.

Signed-off-by: Simon Glass <sjg at chromium.org>
Reported-by: Coverity (CID: 312952)

Changes in v2:
- Add a standard comment instead of a Coverity annotation

 drivers/reset/reset-uclass.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c
index ac89eaf098a..a3a088d1b5c 100644
--- a/drivers/reset/reset-uclass.c
+++ b/drivers/reset/reset-uclass.c
@@ -323,6 +323,8 @@ struct reset_ctl_bulk *devm_reset_bulk_get_by_node(struct udevice *dev,
 	bulk = devres_alloc(devm_reset_bulk_release,
 			    sizeof(struct reset_ctl_bulk),
+	/* this looks like a leak, but devres takes care of it */
 	if (unlikely(!bulk))
 		return ERR_PTR(-ENOMEM);

More information about the U-Boot mailing list