[PATCH v2 06/16] reset: Avoid a warning in devm_regmap_init()

Simon Glass sjg at chromium.org
Fri May 14 03:39:22 CEST 2021


The devres_alloc() function is intended to avoid the need for freeing
memory, although in practice it may not be enabled, thus leading to a true
leak.

Nevertheless this is intended. Add a comment.

Signed-off-by: Simon Glass <sjg at chromium.org>
Reported-by: Coverity (CID: 312951)
---

Changes in v2:
- Add a standard comment instead of a Coverity annotation

 drivers/core/regmap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/core/regmap.c b/drivers/core/regmap.c
index b51ce108c14..982c2ee9fab 100644
--- a/drivers/core/regmap.c
+++ b/drivers/core/regmap.c
@@ -293,6 +293,7 @@ struct regmap *devm_regmap_init(struct udevice *dev,
 	int rc;
 	struct regmap **mapp, *map;
 
+	/* this looks like a leak, but devres takes care of it */
 	mapp = devres_alloc(devm_regmap_release, sizeof(struct regmap *),
 			    __GFP_ZERO);
 	if (unlikely(!mapp))
-- 
2.31.1.751.gd2f1c929bd-goog



More information about the U-Boot mailing list