[PATCH] pinctrl: single: Fix probe failure getting register area size

[Tom Rini]

On Fri, May 07, 2021 at 02:40:34PM +0530, Vignesh Raghavendra wrote:

> If reg property of pinctrl-single node requires address translation then
> probe fails with following message:
> 
> single-pinctrl pinctrl at 4301c000: failed to get base register size
> 
> This is because driver uses dev_read_addr_size() to get size which also
> tries to fetch untranslated addr and fails.
> Fix this by using dev_read_addr_size_index() which takes care of address
> translation and also makes following dev_read_addr() call redundant.
> 
> This fixes Ethernet failures on TI's AM654 based EVMs due to lack of
> pinmux configuration.
> 
> Fixes: 9fd8a430f3 ("pinctrl: single: get register area size by device API")
> Signed-off-by: Vignesh Raghavendra <vigneshr at ti.com>
> ---
>  drivers/pinctrl/pinctrl-single.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index ebb7602dde..7af6c5f0b0 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -509,19 +509,13 @@ static int single_of_to_plat(struct udevice *dev)
>  		return -EINVAL;
>  	}
>  
> -	addr = dev_read_addr_size(dev, "reg", &size);
> +	addr = dev_read_addr_size_index(dev, 0, &size);
>  	if (addr == FDT_ADDR_T_NONE) {
> -		dev_err(dev, "failed to get base register size\n");
> +		dev_err(dev, "failed to get base register address\n");
>  		return -EINVAL;
>  	}
>  
>  	pdata->offset = size - pdata->width / BITS_PER_BYTE;
> -
> -	addr = dev_read_addr(dev);
> -	if (addr == FDT_ADDR_T_NONE) {
> -		dev_dbg(dev, "no valid base register address\n");
> -		return -EINVAL;
> -	}
>  	pdata->base = addr;
>  
>  	ret = dev_read_u32(dev, "pinctrl-single,function-mask", &pdata->mask);

Dario, since this has a fixes tag for a commit of yours, comments?
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210517/b91caa00/attachment.sig>