[PATCH 15/16] fdt: Make OF_BOARD a bool option

Sean Anderson seanga2 at gmail.com
Wed Oct 13 19:30:18 CEST 2021


On 10/13/21 12:58 PM, Simon Glass wrote:
> Hi Heinrich,
> 
> On Tue, 12 Oct 2021 at 22:22, Heinrich Schuchardt
> <heinrich.schuchardt at canonical.com> wrote:
>>
>>
>>
>> On 10/13/21 03:01, Simon Glass wrote:
>>> This should not be a separate option from OF_SEPARATE. It is a run-time
>>> option to override the devicetree, even if present.
>>>
>>> Move the option out of the choice.
>>>
>>> Disable BINMAN_FDT for a few boards which don't actually use it.
>>
>> You only sent patch 6/16 and 15/16 to me. No clue why. Please, send
>> complete patch sets instead of selected patches which cannot be reviewed
>> without the context.
> 
> I actually only explicitly cc'd Ilias (who has been working on similar
> things) and Tom. Everyone else came in via maintainer files. Can you
> see the rest in the mailing list, assuming you are subscribed? I can
> add you to the next version.
> 
> For the record, here is what patman produced:

FWIW I have always thought that patman CCs too many people by default.
It is only partially based on MAINTAINERS; the rest of the CCs are from
people who have touched the file recently. This results in many people
being CC'd who have made only minor or unrelated changes to the code
(especially from treewide changes). For this reason, I curate my CCs
manually to hopefully CC only those people who are actually interested
in my patches.

--Sean

> $ patman -n
> Cleaned 16 patches
> ...
> checkpatch.pl found 0 error(s), 14 warning(s), 0 checks(s)
> Not sending emails due to errors/warnings
> Dry run, so not doing much. But I would do this:
> 
> Send a total of 16 patches with a cover letter.
>     0001-arm-qemu-Mention-nographic-in-the-docs.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  qemu-devel at nongnu.org
>     0002-arm-qemu-Explain-how-to-extract-the-generate-devicet.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  qemu-devel at nongnu.org
>     0003-riscv-qemu-Explain-how-to-extract-the-generate-devic.patch
>        Cc:  Atish Patra <atish.patra at wdc.com>
>        Cc:  Bin Meng <bin.meng at windriver.com>
>        Cc:  Heinrich Schuchardt <xypron.glpk at gmx.de>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  qemu-devel at nongnu.org
>     0004-arm-qemu-Add-a-devicetree-file-for-qemu_arm.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Sean Anderson <seanga2 at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>        Cc:  Tuomas Tynkkynen <tuomas.tynkkynen at iki.fi>
>        Cc:  qemu-devel at nongnu.org
>     0005-arm-qemu-Add-a-devicetree-file-for-qemu_arm64.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Sean Anderson <seanga2 at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>        Cc:  Tuomas Tynkkynen <tuomas.tynkkynen at iki.fi>
>        Cc:  qemu-devel at nongnu.org
>     0006-riscv-qemu-Add-devicetree-files-for-qemu_riscv32-64.patch
>        Cc:  Bin Meng <bmeng.cn at gmail.com>
>        Cc:  David Abdurachmanov <david.abdurachmanov at sifive.com>
>        Cc:  Dimitri John Ledkov <dimitri.ledkov at canonical.com>
>        Cc:  Green Wan <green.wan at sifive.com>
>        Cc:  Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>        Cc:  Jonathan Balkind <jbalkind at ucsb.edu>
>        Cc:  Leo <ycliang at andestech.com>
>        Cc:  Padmarao Begari <padmarao.begari at microchip.com>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Sean Anderson <seanga2 at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Tianrui Wei <tianrui-wei at outlook.com>
>        Cc:  Zong Li <zong.li at sifive.com>
>        Cc:  qemu-devel at nongnu.org
>     0007-arm-rpi-Add-a-devicetree-file-for-rpi_4.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Matthias Brugger <mbrugger at suse.com>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Stephen Warren <swarren at nvidia.com>
>        Cc:  Stephen Warren <swarren at wwwdotorg.org>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>     0008-arm-vexpress-Add-a-devicetree-file-for-juno.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Bin Meng <bin.meng at windriver.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Linus Walleij <linus.walleij at linaro.org>
>        Cc:  Liviu Dudau <liviu.dudau at foss.arm.com>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Sean Anderson <seanga2 at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>     0009-arm-xenguest_arm64-Add-a-fake-devicetree-file.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Anastasiia Lukianenko <anastasiia_lukianenko at epam.com>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Bin Meng <bin.meng at windriver.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Oleksandr Andrushchenko <oleksandr_andrushchenko at epam.com>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Sean Anderson <seanga2 at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>     0010-arm-octeontx-Add-a-fake-devicetree-file.patch
>        Cc:  Aaron Williams <awilliams at marvell.com>
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Sean Anderson <seanga2 at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Stefan Roese <sr at denx.de>
>        Cc:  Tero Kristo <kristo at kernel.org>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>     0011-arm-xilinx_versal_virt-Add-a-devicetree-file.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Ashok Reddy Soma <ashok.reddy.soma at xilinx.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Michal Simek <michal.simek at xilinx.com>
>        Cc:  Michal Simek <monstr at monstr.eu>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  T Karthik Reddy <t.karthik.reddy at xilinx.com>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>     0012-arm-bcm7xxx-Add-a-devicetree-file.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Thomas Fitzsimmons <fitzsim at fitzsim.org>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>     0013-arm-qemu-ppce500-Add-a-devicetree-file.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Alexander Graf <agraf at csgraf.de>
>        Cc:  Bin Meng <bmeng.cn at gmail.com>
>        Cc:  Niel Fourie <lusus at denx.de>
>        Cc:  Priyanka Jain <priyanka.jain at nxp.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Sinan Akman <sinan at writeme.com>
>        Cc:  Stefan Roese <sr at denx.de>
>        Cc:  Valentin Longchamp <valentin.longchamp at hitachi-powergrids.com>
>        Cc:  Vladimir Oltean <vladimir.oltean at nxp.com>
>        Cc:  Wolfgang Denk <wd at denx.de>
>     0014-arm-highbank-Add-a-fake-devicetree-file.patch
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Ramon Fried <rfried.dev at gmail.com>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Sean Anderson <seanga2 at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>     0015-fdt-Make-OF_BOARD-a-bool-option.patch
>        Cc:  Bin Meng <bmeng.cn at gmail.com>
>        Cc:  Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>        Cc:  Jerry Van Baren <vanbaren at cideas.com>
>        Cc:  Leo Yu-Chi Liang <ycliang at andestech.com>
>        Cc:  Priyanka Jain <priyanka.jain at nxp.com>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Sean Anderson <seanga2 at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Vladimir Oltean <vladimir.oltean at nxp.com>
>     0016-Drop-CONFIG_BINMAN_STANDALONE_FDT.patch
>        Cc:  Bin Meng <bmeng.cn at gmail.com>
>        Cc:  Marek Behún <marek.behun at nic.cz>
>        Cc:  Pali Rohár <pali at kernel.org>
>        Cc:  Simon Glass <sjg at chromium.org>
> To:   U-Boot Mailing List <u-boot at lists.denx.de>
> To:   u-boot at lists.denx.de
> Cc:   Ilias Apalodimas <ilias.apalodimas at linaro.org>
> Cc:   Tom Rini <trini at konsulko.com>
> Version:  None
> Prefix:   None
> Cover: 36 lines
>        Cc:  Aaron Williams <awilliams at marvell.com>
>        Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
>        Cc:  Alexander Graf <agraf at csgraf.de>
>        Cc:  Anastasiia Lukianenko <anastasiia_lukianenko at epam.com>
>        Cc:  Andre Przywara <andre.przywara at arm.com>
>        Cc:  Ashok Reddy Soma <ashok.reddy.soma at xilinx.com>
>        Cc:  Atish Patra <atish.patra at wdc.com>
>        Cc:  Bin Meng <bin.meng at windriver.com>
>        Cc:  Bin Meng <bmeng.cn at gmail.com>
>        Cc:  Christian Hewitt <christianshewitt at gmail.com>
>        Cc:  David Abdurachmanov <david.abdurachmanov at sifive.com>
>        Cc:  Dimitri John Ledkov <dimitri.ledkov at canonical.com>
>        Cc:  Fabio Estevam <festevam at gmail.com>
>        Cc:  Green Wan <green.wan at sifive.com>
>        Cc:  Heiko Schocher <hs at denx.de>
>        Cc:  Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>        Cc:  Heinrich Schuchardt <xypron.glpk at gmx.de>
>        Cc:  Jagan Teki <jagan at amarulasolutions.com>
>        Cc:  Jerry Van Baren <vanbaren at cideas.com>
>        Cc:  Jonathan Balkind <jbalkind at ucsb.edu>
>        Cc:  Kever Yang <kever.yang at rock-chips.com>
>        Cc:  Leo <ycliang at andestech.com>
>        Cc:  Leo Yu-Chi Liang <ycliang at andestech.com>
>        Cc:  Linus Walleij <linus.walleij at linaro.org>
>        Cc:  Liviu Dudau <liviu.dudau at foss.arm.com>
>        Cc:  Marek Behún <marek.behun at nic.cz>
>        Cc:  Matthias Brugger <mbrugger at suse.com>
>        Cc:  Michal Simek <michal.simek at xilinx.com>
>        Cc:  Michal Simek <monstr at monstr.eu>
>        Cc:  Neil Armstrong <narmstrong at baylibre.com>
>        Cc:  Niel Fourie <lusus at denx.de>
>        Cc:  Oleksandr Andrushchenko <oleksandr_andrushchenko at epam.com>
>        Cc:  Padmarao Begari <padmarao.begari at microchip.com>
>        Cc:  Pali Rohár <pali at kernel.org>
>        Cc:  Peter Robinson <pbrobinson at gmail.com>
>        Cc:  Priyanka Jain <priyanka.jain at nxp.com>
>        Cc:  Ramon Fried <rfried.dev at gmail.com>
>        Cc:  Rick Chen <rick at andestech.com>
>        Cc:  Sean Anderson <seanga2 at gmail.com>
>        Cc:  Simon Glass <sjg at chromium.org>
>        Cc:  Sinan Akman <sinan at writeme.com>
>        Cc:  Stefan Roese <sr at denx.de>
>        Cc:  Stephen Warren <swarren at nvidia.com>
>        Cc:  Stephen Warren <swarren at wwwdotorg.org>
>        Cc:  T Karthik Reddy <t.karthik.reddy at xilinx.com>
>        Cc:  Tero Kristo <kristo at kernel.org>
>        Cc:  Thomas Fitzsimmons <fitzsim at fitzsim.org>
>        Cc:  Tianrui Wei <tianrui-wei at outlook.com>
>        Cc:  Tim Harvey <tharvey at gateworks.com>
>        Cc:  Tuomas Tynkkynen <tuomas.tynkkynen at iki.fi>
>        Cc:  Valentin Longchamp <valentin.longchamp at hitachi-powergrids.com>
>        Cc:  Vladimir Oltean <vladimir.oltean at nxp.com>
>        Cc:  Wolfgang Denk <wd at denx.de>
>        Cc:  Zong Li <zong.li at sifive.com>
>        Cc:  qemu-devel at nongnu.org
> 
> Regards,
> Simon
> 





More information about the U-Boot mailing list