[PATCH 15/16] fdt: Make OF_BOARD a bool option

Simon Glass sjg at chromium.org
Sun Oct 24 21:53:14 CEST 2021


Hi Sean,

On Wed, 13 Oct 2021 at 11:30, Sean Anderson <seanga2 at gmail.com> wrote:
>
> On 10/13/21 12:58 PM, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Tue, 12 Oct 2021 at 22:22, Heinrich Schuchardt
> > <heinrich.schuchardt at canonical.com> wrote:
> >>
> >>
> >>
> >> On 10/13/21 03:01, Simon Glass wrote:
> >>> This should not be a separate option from OF_SEPARATE. It is a run-time
> >>> option to override the devicetree, even if present.
> >>>
> >>> Move the option out of the choice.
> >>>
> >>> Disable BINMAN_FDT for a few boards which don't actually use it.
> >>
> >> You only sent patch 6/16 and 15/16 to me. No clue why. Please, send
> >> complete patch sets instead of selected patches which cannot be reviewed
> >> without the context.
> >
> > I actually only explicitly cc'd Ilias (who has been working on similar
> > things) and Tom. Everyone else came in via maintainer files. Can you
> > see the rest in the mailing list, assuming you are subscribed? I can
> > add you to the next version.
> >
> > For the record, here is what patman produced:
>
> FWIW I have always thought that patman CCs too many people by default.
> It is only partially based on MAINTAINERS; the rest of the CCs are from
> people who have touched the file recently. This results in many people
> being CC'd who have made only minor or unrelated changes to the code
> (especially from treewide changes). For this reason, I curate my CCs
> manually to hopefully CC only those people who are actually interested
> in my patches.

Patman uses only the commit tags and get_maintainers, so the fault may
live with the latter?

Regards,
Simon


More information about the U-Boot mailing list