[PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux

Michael Walle michael at walle.cc
Wed Sep 1 13:51:53 CEST 2021


Am 2021-09-01 13:24, schrieb Vladimir Oltean:
> On Wed, Sep 01, 2021 at 10:55:21AM +0200, Michael Walle wrote:
>> -		usb0: usb3 at 3100000 {
>> -			compatible = "fsl,layerscape-dwc3";
>> -			reg = <0x0 0x3100000 0x0 0x10000>;
>> -			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
>> -			dr_mode = "host";
>> -			status = "disabled";
>> -		};
>> -
>> -		usb1: usb3 at 3110000 {
>> -			compatible = "fsl,layerscape-dwc3";
>> -			reg = <0x0 0x3110000 0x0 0x10000>;
>> -			interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
>> -			dr_mode = "host";
>> +		usb0: usb at 3100000 {
>> +			compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
>> +			reg = <0x0 0x3100000 0x0 0x10000>;
>> +			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
>> +			dr_mode = "host";
>> +			snps,dis_rxdet_inp3_quirk;
>> +			snps,quirk-frame-length-adjustment = <0x20>;
>> +			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
>> +		};
>> +
>> +		usb1: usb at 3110000 {
>> +			compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
>> +			reg = <0x0 0x3110000 0x0 0x10000>;
>> +			interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
>> +			dr_mode = "host";
>> +			snps,dis_rxdet_inp3_quirk;
>> +			snps,quirk-frame-length-adjustment = <0x20>;
>> +			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
>> +		};
> 
> I see the status = 'disabled' was lost in the new bindings? This is
> strange considering that it is you who sent the patch to disable them 
> in
> Linux, just yesterday:
> https://lkml.org/lkml/2021/8/31/426

Yes but that is on purpose. In the current u-boot device tree, it was
disabled, but the boards reenabled them again. So it didn't matter.

I want to have a specific sync point (that is the v5.14 tag) for the
.dtsi. At least where possible; for phy-mode and so on I needed to to
take additional patches which weren't picked up in linux yet, but
these just affect the sl28 board device trees.

-michael


More information about the U-Boot mailing list