[PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux

[Michael Walle]

Am 2021-09-01 13:55, schrieb Vladimir Oltean:
> On Wed, Sep 01, 2021 at 01:51:53PM +0200, Michael Walle wrote:
>> Yes but that is on purpose. In the current u-boot device tree, it was
>> disabled, but the boards reenabled them again. So it didn't matter.
>> 
>> I want to have a specific sync point (that is the v5.14 tag) for the
>> .dtsi. At least where possible; for phy-mode and so on I needed to to
>> take additional patches which weren't picked up in linux yet, but
>> these just affect the sl28 board device trees.
> 
> Binary compatibility is one thing and I can understand it.
> Textual compatibility, down to label names, and where the device is
> being disabled from? Hmmmm, I'm having a hard time saying yes to that.

It's a step back, yes. But only until v5.16 (I don't think the changes
will make it during the merge window). I guess you are concerned because
of your vendor fork? Mh, well actually I don't understand your concert,
because your tree isn't compatible anyway if we change the labels.

We'd trade the clear information where the device tree is from for
something that - in my opinion - is not worth it. I mean the device
tree (source) is used just here in u-boot for these three boards and
all have the usb nodes enabled.

> (btw I finished reviewing this patch, I have no other comments)

thanks for the efforts!

-michael