Subject: [PATCH 0/6] Add support for SDM845 based boards, and SM-G9600

Ramon Fried rfried.dev at gmail.com
Sun Sep 5 15:43:35 CEST 2021


On Tue, Aug 31, 2021 at 11:42 AM Дмитрий Санковский
<dsankouski at gmail.com> wrote:
>
> From 94e21cc200e09c51752e4bb86cfac320a92c48a5 Mon Sep 17 00:00:00 2001
> From: Dzmitry Sankouski <dsankouski at gmail.com>
> Date: Tue, 31 Aug 2021 11:25:37 +0300
> Subject: [PATCH 0/6] Add support for SDM845 based boards, and SM-G9600
>
> Snapdragon 845 - hi-end qualcomm chip, introduced in late 2017.
> Mostly used in flagship phones and tablets of 2018.
> Features:
> - arm64 arch
> - total of 8 Kryo 385 Gold / Silver cores
> - Hexagon 685 DSP
> - Adreno 630 GPU
>
> Tested only as second-stage bootloader.
>
> Samsung S9 SM-G9600 - Snapdragon SDM845 version of the phone,
> for China \ Hong Kong markets.
> Has unlockable bootloader, unlike SM-G960U (American market version),
> which allows running u-boot as a chain-loaded bootloader.
>
> Dzmitry Sankouski (6):
>   serial: qcom: add support for GENI serial driver
>   spmi: msm: add arbiter version 5 support
>   pinctrl: qcom: add pinctrl and gpio drivers for SDM845  SoC
>   clocks: qcom: add clocks for SDM845 debug uart
>   SoC: qcom: add support for SDM845
>   board: samsung: add Samsung Galaxy S9/S9+(SM-G96x0) board
>
>  MAINTAINERS                                   |   2 +
>  arch/arm/dts/Makefile                         |   1 +
>  arch/arm/dts/sdm845.dtsi                      | 118 ++++
>  arch/arm/dts/starqltechn-uboot.dtsi           |  39 ++
>  arch/arm/dts/starqltechn.dts                  |  53 ++
>  arch/arm/mach-snapdragon/Kconfig              |  17 +
>  arch/arm/mach-snapdragon/Makefile             |   4 +
>  arch/arm/mach-snapdragon/clock-sdm845.c       |  92 +++
>  arch/arm/mach-snapdragon/clock-snapdragon.c   |   1 +
>  arch/arm/mach-snapdragon/clock-snapdragon.h   |   3 +-
>  .../include/mach/sysmap-sdm845.h              |  42 ++
>  arch/arm/mach-snapdragon/init_sdm845.c        |  82 +++
>  arch/arm/mach-snapdragon/pinctrl-sdm845.c     |  44 ++
>  arch/arm/mach-snapdragon/pinctrl-snapdragon.c |   1 +
>  arch/arm/mach-snapdragon/pinctrl-snapdragon.h |   1 +
>  arch/arm/mach-snapdragon/sysmap-sdm845.c      |  31 +
>  board/samsung/starqltechn/Kconfig             |  14 +
>  board/samsung/starqltechn/MAINTAINERS         |   6 +
>  board/samsung/starqltechn/Makefile            |   9 +
>  board/samsung/starqltechn/starqltechn.c       |  10 +
>  configs/starqltechn_defconfig                 |  33 +
>  .../serial/msm-geni-serial.txt                |   6 +
>  drivers/gpio/msm_gpio.c                       |   1 +
>  drivers/gpio/pm8916_gpio.c                    |   8 +-
>  drivers/serial/Kconfig                        |  17 +
>  drivers/serial/Makefile                       |   1 +
>  drivers/serial/serial_msm_geni.c              | 579 ++++++++++++++++++
>  drivers/spmi/spmi-msm.c                       | 156 +++--
>  include/configs/sdm845.h                      |  32 +
>  include/configs/starqltechn.h                 |  16 +
>  30 files changed, 1365 insertions(+), 54 deletions(-)
>  create mode 100644 arch/arm/dts/sdm845.dtsi
>  create mode 100644 arch/arm/dts/starqltechn-uboot.dtsi
>  create mode 100644 arch/arm/dts/starqltechn.dts
>  create mode 100644 arch/arm/mach-snapdragon/clock-sdm845.c
>  create mode 100644 arch/arm/mach-snapdragon/include/mach/sysmap-sdm845.h
>  create mode 100644 arch/arm/mach-snapdragon/init_sdm845.c
>  create mode 100644 arch/arm/mach-snapdragon/pinctrl-sdm845.c
>  create mode 100644 arch/arm/mach-snapdragon/sysmap-sdm845.c
>  create mode 100644 board/samsung/starqltechn/Kconfig
>  create mode 100644 board/samsung/starqltechn/MAINTAINERS
>  create mode 100644 board/samsung/starqltechn/Makefile
>  create mode 100644 board/samsung/starqltechn/starqltechn.c
>  create mode 100644 configs/starqltechn_defconfig
>  create mode 100644 doc/device-tree-bindings/serial/msm-geni-serial.txt
>  create mode 100644 drivers/serial/serial_msm_geni.c
>  create mode 100644 include/configs/sdm845.h
>  create mode 100644 include/configs/starqltechn.h
>
> --
> 2.20.1
>
Hi.
Nicely done, please run checkpatch on everything, I think I noticed
some spacing errors, but I'm not certain.
Also, please add board documentation file, the earlier snapdragon
boards have an example under the board directory, but you should place
yours
under doc/board/qcom/sdm845.rst

See the other boards there for reference.
Thanks,
Ramon.


More information about the U-Boot mailing list