[PATCH v2 1/6] common: Remove unused CONFIG_FIT_SHAxxx selectors

Tom Rini trini at konsulko.com
Thu Sep 9 03:25:09 CEST 2021


On Thu, Sep 02, 2021 at 07:54:17PM -0500, Alexandru Gagniuc wrote:

> Originally CONFIG_FIT_SHAxxx enabled specific SHA algos for and only
> for hash_calculate() in common/image-fit.c. However, since commit
> 14f061dcb1 ("image: Drop IMAGE_ENABLE_SHAxxx"),
> the correct selector was changed to CONFIG_SHAxxx.
> 
> The extra "_FIT_" variants are neither used, nor needed. Remove them.
> One defconfig disables FIT_SHA256, which is now changed to 'SHA256'.
> 
> CMD_MVEBU_BUBT needs to select select SHA256 to avoid undefined
> references to "sha256_*()". bubt.c needs sha256, so this selection is
> correct. It is not clear why this problem did not manifest before.
> 
> Note that SHA selection in SPL is broken for this exact reason. There
> is no corresponding SPL_SHAxxx. Fixing this is is beyond the scope of
> this change.
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>

After making SHA256 be an implied option under FIT, to mirror the
current behavior, applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210908/11a42f96/attachment.sig>


More information about the U-Boot mailing list