[PATCH 1/1] configs: add mkeficapsule to tools-only_defconfig

[Heinrich Schuchardt]

On 9/9/21 8:09 AM, AKASHI Takahiro wrote:
> On Thu, Sep 09, 2021 at 07:27:10AM +0200, Heinrich Schuchardt wrote:
>> mkeficapsule is used to create capsules for UEFI firmware update.
>> To ease inclusion into U-Boot tools packages of Linux distributions we
>> should add it to the tools-only_defconfig.
>>
>> Provide dummy values for CONFIG_AVB_BUF_ADDR, CONFIG_AVB_BUF_SIZE to
>> satisfy Kconfig.
>>
>> Suggested-by: Vagrant Cascadian <vagrant at debian.org>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>>   configs/tools-only_defconfig | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig
>> index f54bc1802c..8a20d3fb05 100644
>> --- a/configs/tools-only_defconfig
>> +++ b/configs/tools-only_defconfig
>> @@ -5,6 +5,8 @@ CONFIG_ANDROID_BOOT_IMAGE=y
>>   CONFIG_FIT=y
>>   CONFIG_FIT_SIGNATURE=y
>>   CONFIG_MISC_INIT_F=y
>> +CONFIG_AVB_BUF_ADDR=0x0
>> +CONFIG_AVB_BUF_SIZE=0x8192
>>   # CONFIG_CMD_BOOTD is not set
>>   # CONFIG_CMD_BOOTM is not set
>>   # CONFIG_CMD_ELF is not set
>> @@ -29,4 +31,7 @@ CONFIG_SYSRESET=y
>>   # CONFIG_VIRTIO_MMIO is not set
>>   # CONFIG_VIRTIO_PCI is not set
>>   # CONFIG_VIRTIO_SANDBOX is not set
>> -# CONFIG_EFI_LOADER is not set
>> +CONFIG_EFI_CAPSULE_ON_DISK=y
>> +CONFIG_EFI_CAPSULE_FIRMWARE_FIT=y
>> +CONFIG_EFI_CAPSULE_FIRMWARE_RAW=y
>> +CONFIG_EFI_CAPSULE_AUTHENTICATE=y
>
> I think that we should use the way that I suggested in my patch[1].
>
> -Takahiro Akashi
>
> [1] https://lists.denx.de/pipermail/u-boot/2021-August/459349.html

Your patch [1] still requires some rework:
https://patchwork.ozlabs.org/project/uboot/patch/20210831024659.53464-2-takahiro.akashi@linaro.org/

[1] changes what mkeficapsule looks like and this patch makes it
available in tools-only_defconfig?

Aren't these two patches complementary?

Where do you see the conflict?

Best regards

Heinrich

>
>> --
>> 2.30.2
>>