[PATCH 13/35] efi: Add a media/block driver for EFI block devices

[Simon Glass]

Hi Heinrich,

On Wed, 8 Sept 2021 at 12:04, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
>
>
> On 9/8/21 3:33 PM, Simon Glass wrote:
> > Add a block driver which handles read/write for EFI block devices. This
> > driver actually already exists ('efi_block') but is not really suitable
> > for use as a real U-Boot driver:
> >
> > - The operations do not provide a udevice
>
> efi_bl_bind() creates a udevice by calling blk_create_device() when an
> EFI application calls ConnectController() for a handle with an
> EFI_BLOCK_IO_PROTOCOL.
>
> Please, explain in some detail what you think is wrong with the existing
> code.

See below:

>
> > - The code is designed for running as part of EFI loader, so uses
> >      EFI_PRINT() and EFI_CALL().
> > - It creates block devices for all the partitions too, which is not
> >    somthing we want to support in this way
> > - The bind method probes the device, which is not permitted
> > - It uses 'EFI' as its parent device
> >
> > The new driver is more 'normal', just requiring its platform data be set
> > up in advance.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
>
> Please, separate this series in two. One for U-Boot on EFI and one for
> U-Boot's UEFI implementation.

Again I'm not sure what you mean here. Please point to something you
don't want in this series, which is focussed on the app.

>
> Best regardss
>
> Heinrich
>
> > ---
> >
> >   drivers/block/Kconfig   |  10 ++++
> >   drivers/block/Makefile  |   1 +
> >   drivers/block/efi_blk.c | 115 ++++++++++++++++++++++++++++++++++++++++
> >   include/efi.h           |  11 ++++
> >   4 files changed, 137 insertions(+)
> >   create mode 100644 drivers/block/efi_blk.c
> >

Regards,
Simon