[PATCH 34/35] efi: Show when allocated pages are used

Simon Glass sjg at chromium.org
Thu Sep 9 21:58:37 CEST 2021


Hi Heinrich.

On Thu, 9 Sept 2021 at 04:44, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
>
>
> On 9/9/21 10:57 AM, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Wed, 8 Sept 2021 at 12:25, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >>
> >>
> >>
> >> On 9/8/21 3:34 PM, Simon Glass wrote:
> >>> Add a message here so that both paths of memory allocation are reported.
> >>>
> >>> Signed-off-by: Simon Glass <sjg at chromium.org>
> >>> ---
> >>>
> >>>    lib/efi/efi_app.c | 1 +
> >>>    1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/lib/efi/efi_app.c b/lib/efi/efi_app.c
> >>> index e0666d1fae2..c8f4784eb7d 100644
> >>> --- a/lib/efi/efi_app.c
> >>> +++ b/lib/efi/efi_app.c
> >>> @@ -97,6 +97,7 @@ static efi_status_t setup_memory(struct efi_priv *priv)
> >>>                        return ret;
> >>>                priv->use_pool_for_malloc = true;
> >>>        } else {
> >>> +             printf("(using allocated RAM address %lx) ", (ulong)addr);
> >>
> >> Shouldn't this be log_debug()?
> >
> > It matches the one a few lines higher. I suppose it could be a debug
> > statement, but allocation is an area that seems to different on
> > different UEFIs, so I have it more prominent for the moment, until we
> > figure it out.
>
> If you want it more prominent, isn't it log_info() that you were promoting?

OK I can change them both, so long as logging is enabled for EFI...will check.

Regards,
Simon


More information about the U-Boot mailing list