[PATCH v1 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

[Andy Shevchenko]

On Fri, Sep 10, 2021 at 7:16 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> On Sat, Sep 11, 2021 at 12:07 AM Andy Shevchenko
> <andy.shevchenko at gmail.com> wrote:
> > On Fri, Sep 10, 2021 at 2:38 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> > > On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko
> > > <andriy.shevchenko at linux.intel.com> wrote:
> > > > On Intel Tangier the SDHCI #2 provides SD card connection.
> > > > Add GPIO card detection for it.
> > > >
> > > > Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier")
> > > > BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > > > ---
> > > >  .../asm/arch-tangier/acpi/southcluster.asl    | 32 +++++++++++++++++++
> > > >  1 file changed, 32 insertions(+)
> > >
> > > Acked-by: Bin Meng <bmeng.cn at gmail.com>
> >
> > Thanks!
> >
> > I think I need to adjust the IRQ flags, i.e. to put it as Exclusive and Wake.
> > So I'll send a v2, but I'll keep your tag, I hope that's fine.
>
> Sure!

Thinkg more about it. Intel Edison is a DIY-ish module and perhaps not
everybody want to use SD card or (since there are not so many GPIOs
are made out for use) take SD CD exclusively for it. So, I think the
initial intention is better, But what I would change is a bias to be
PullUp dues to some PCB misconfigurations (no external PU resistor).
v2 soon on its way.

-- 
With Best Regards,
Andy Shevchenko